fix: Strip leading ./
in S3 key if artifacts_dir
is set to something like ${path.root}/mypath/
#168
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change strips the leading
./
in S3 key ifartifacts_dir
is set to something like${path.root}/mypath/
.Motivation and Context
Without this change, this configuration:
gives the following plan excerpt:
Which fails at apply:
With this change, this part of the plan:
applies successfully.
Breaking Changes
This should not be a breaking change as keys with a leading
./
are not accepted by S3.How Has This Been Tested?
examples/*
projectsTested with
examples/complete
withbuild_in_docker = true
added as I only havepython3.9
locally: terraform-aws-lambda-168.logI have also tested this change with my own terraform configurations.