feat: Added support for event source mapping in alias submodule #320
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 16, 2022 17:32
antonbabenko
requested changes
Jun 16, 2022
Thanks for those suggestions, they have made it cleaner. |
antonbabenko
approved these changes
Jun 16, 2022
|
Thank you for this addition! |
antonbabenko
pushed a commit
that referenced
this pull request
Jun 16, 2022
## [3.3.0](v3.2.1...v3.3.0) (2022-06-16) ### Features * Added support for event source mapping in alias submodule ([#320](#320)) ([af22d00](af22d00))
|
This PR is included in version 3.3.0 🎉 |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change adds the ability to configure event source mapping on a Lambda Alias, instead of just the base Lambda. The code to configure the event source mapping was pulled from the main Lambda module and ported to the alias module.
Motivation and Context
We extensively target a Lambda alias for all our use cases in our environment, currently setting this purely via the module isn't possible.
Breaking Changes
No
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectsRan terraform apply to
examples/aliasand then made my changes to the module and ran another apply. No changes were detected. Added new examples and ran another apply. Resources deployed successfully.pre-commit run -aon my pull request