feat: Add Typesense module #1446
Conversation
✅ Deploy Preview for testcontainers-dotnet ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Not sure why Pulsar failed, I don't believe I impacted that? |
No, the PR isn't related. It's Pulsar... It seems like the consumer sometimes isn't in a working state. I'll try to review it in the next days. |
TheConstructor
left a comment
There was a problem hiding this comment.
I just had a very brief look at your code and added two questions
HofmeisterAn
left a comment
There was a problem hiding this comment.
I've updated the PR to follow the repository standards.
We only create container builder APIs for settings that are absolutely necessary to start the container. If a setting can be configured with methods like WithCommand(string), we avoid adding separate APIs to keep it simple.
I removed the --cors flag. When it's always set, developers can't disable it later.
The container configuration type only includes properties needed to modify the setup in Build() or needed in the container type.
LMKWYT. Happy to merge the PR if you're okay with the changes.
|
@HofmeisterAn Yeah, thank you for doing that. Been quite busy lately and just getting back to it now. The changes look good to me. Thanks again, I really appreciate it! |
HofmeisterAn
left a comment
There was a problem hiding this comment.
@HofmeisterAn Yeah, thank you for doing that. Been quite busy lately and just getting back to it now. The changes look good to me. Thanks again, I really appreciate it!
Oh, no worries. Thanks for the contribution!
What does this PR do?
Adds Typesense testcontainers implementation.
Why is it important?
No Typesense Module currently available for Dotnet.
Related issues
No existing issues found related to Typesense.
How to test this PR
tests/Testcontainers.Typesense.Tests contains two tests: