-
Notifications
You must be signed in to change notification settings - Fork 331
feat(core): DockerCompose: support list of env_files #847
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Not sure who is best to ask, so I will try @alexanderankin 😛 Could you or someone take a look at this when they have a chance? It is a backwards compatible 6 line change, so hopefully it will be painless. Thanks! (Apologies for the pestering if you just haven't had time to see this PR yet) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Thanks! It looks like the PR still needs approval to run the workflows before it can be merged? |
i was gonna rerun the failed runs from before and then there was a merge which means all jobs have to run again, so i have to start over and hope for no pypi timeouts this time (they are quite rare to be fair) |
oops my bad! I shouldn't have done that merge (thought it was blocking the PR) |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #847 +/- ##
=======================================
Coverage ? 81.79%
=======================================
Files ? 14
Lines ? 890
Branches ? 140
=======================================
Hits ? 728
Misses ? 127
Partials ? 35 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
🤖 I have created a release *beep* *boop* --- ## [4.13.0](testcontainers-v4.12.0...testcontainers-v4.13.0) (2025-08-27) ### Features * **azurite:** Enhance connection string generation for network and local access ([#859](#859)) ([b21e5e3](b21e5e3)) * **core:** add enhanced wait strategies ([#855](#855)) ([60d21f8](60d21f8)) * **core:** DockerCompose: support list of env_files ([#847](#847)) ([fe206eb](fe206eb)) ### Bug Fixes * assert-in-get_container_host_ip-before-start ([#862](#862)) ([fc4155e](fc4155e)) * **core:** improper reading of .testcontainers.properties ([#863](#863)) ([350f246](350f246)) * **core:** Make TC_POOLING_INTERVAL/sleep_time a float ([#839](#839)) ([a072f3f](a072f3f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
It is useful to be able to pass a list of
env_file
s, especially since you can pass a list ofcompose_file_name
s.Builds upon #135, matching
compose_file_name
.