fix(server): allow dot-prefixed path segments in static files#2013
Open
NullVoxPopuli wants to merge 1 commit into
Open
fix(server): allow dot-prefixed path segments in static files#2013NullVoxPopuli wants to merge 1 commit into
NullVoxPopuli wants to merge 1 commit into
Conversation
[email protected] (pulled in via Express 5) defaults to dotfiles: 'ignore' and 404s any path with a segment starting with '.'. [email protected] (Express 4) only rejected when the *last* segment did, so paths like `node_modules/.pnpm/[email protected]/...` worked before and don't now. This breaks every pnpm-managed project that serves its build output through testem. Passes { dotfiles: 'allow' } to the res.sendFile calls in serveStaticFile to restore the pre-3.20 behavior. Closes testem#2012
NullVoxPopuli
added a commit
to emberjs/ember.js
that referenced
this pull request
May 23, 2026
NullVoxPopuli
added a commit
to emberjs/ember.js
that referenced
this pull request
May 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[email protected](pulled in via Express 5) defaults todotfiles: 'ignore'and 404s any path with a segment starting with..[email protected](Express 4) only rejected when the last segment did, so paths likenode_modules/.pnpm/[email protected]/...worked before 3.20 and don't now.Passes
{ dotfiles: 'allow' }to bothres.sendFilecalls inserveStaticFileto restore the pre-3.20 behavior. Adds a fixture (tests/web/.pnpm-like/inside.js) and a test case asserting GET/web/.pnpm-like/inside.jsreturns its contents.Closes #2012.