Always send system mails from publisher_email #2040
+14
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fallback to [email protected]
Member
|
@Bloke - Is this viable for 4.9.1, do you think? |
Member
|
Definitely, once I get my head round why it does that extra duplicate check. Probably a code path I've not thought of, so I hope @jools-r can clear it up and make me see the light. |
Member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
If no $from attribute is specified, send system emails using txpMail() from:
logged in user or, when no user is logged in, the recipientsite nameIf the publisher_email is invalid or unset, use [email protected]