Catch KeyError when checking word from cmudict #213
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
latest release of cmudict means that
```python
import textstat
textstat.count_syllables("text_a")
```
causes the error
```python
File "textstat/backend/counts/_count_syllables.py", line 30, in count_syllables
cmu_phones = cmu_dict[word][0]
KeyError: 'text_a'
```
fixes #212 in latest python-cmudict, the dict of syllables is no longer a default dict, so now raises a KeyError
1 task
Member
Author
$ uv run --with git+https://github.com/textstat/textstat.git@main python -c "import textstat; print(textstat.flesch_kincaid_grade('text_a'))" --python=3.10 --isolated --no-project
textstat/backend/counts/_count_syllables.py", line 30, in count_syllables
cmu_phones = cmu_dict[word][0]
KeyError: 'text_a'$ uv run --with git+https://github.com/textstat/textstat.git@cmu-fix python -c "import textstat; print(textstat.flesch_kincaid_grade('text_a'))" --python=3.10 --isolated --no-project
8.400000000000002 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an additional KeyError catch when trying to get a word from cmudict as the latest release of python-cmudict removed the defaultdict.