Require serializers and paginators#512
Open
KorvinSzanto wants to merge 1 commit into
Open
Conversation
Contributor
|
I like this, especially with it being more of a 2.0 goal. But we should figure out whats up with the test suite. |
Nyholm
requested changes
Mar 7, 2022
Nyholm
left a comment
Member
There was a problem hiding this comment.
Im not sure it is a good idea to make these all required.
Contributor
Author
|
@Nyholm Can you be specific about your concerns? The idea is to require these until v2 to ease the transition to the separated repositories. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I like the idea of splitting these repositories out, I think we should wait until v2.0 to exclude them to lower the barrier to 1.0.