[SDK] Add pagination to ERC721's getAllOwners method
#1887
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: e523f0d The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1887 +/- ##
==========================================
+ Coverage 67.50% 67.51% +0.01%
==========================================
Files 291 291
Lines 11017 11016 -1
Branches 1513 1513
==========================================
+ Hits 7437 7438 +1
+ Misses 2955 2952 -3
- Partials 625 626 +1 ☔ View full report in Codecov by Sentry. |
|
/release-pr |
|
/release-pr |
added 2 commits
November 28, 2023 18:16
…web-dev/js into kien/all-owners-pagination
|
Just wanna credit a community member for pointing out what I couldn't see in my code 💀 |
Merged
jnsdls
pushed a commit
that referenced
this pull request
Jun 19, 2024
* quick link fix * coinbase text fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved
Currently this method has no limit on how many items one can query, which create excessive RPC calls. Adding this option should provide users some control over their RPC usage, and should potentially improve the performance of the
useOwnedNFTshookChanges made
How to test