Turkish Language & Cleaning up the language code #1955
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: dfe4690 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
thank you @Visual917 ! super helpful - we'll review this and get it in asap :) |
iketw
reviewed
Nov 16, 2023
|
@Visual917 made the changes here: #1962. Let me know if it looks good to you and I'll merge it :). Thanks for working on this! |
Co-authored-by: iketw <[email protected]> Signed-off-by: V <[email protected]>
Signed-off-by: Jonas Daniels <[email protected]>
Signed-off-by: Jonas Daniels <[email protected]>
|
superseded by #1962 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleaned up the language code
Combined Locales
Created a locales object to link each language code with its data.
Unified Locale Function
Made a getLocale function. It combines the base language data with any extra bits you add. This means you don't have to write the same code for each language.
Streamlined Language Functions
en, es, ja, tr etc now just use getLocale. It's cleaner and makes adding more languages easy. (Hopefully.) I would make them JSON files instead of separate ts files though. But I didn't want to overstep any boundaries.
Overall, I tried getting rid of repetitive if-else stuff.
Added Turkish Language
Created by @selcukemiravci and @Visual917