-
Notifications
You must be signed in to change notification settings - Fork 589
Version Packages #8053
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version Packages #8053
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub.
|
WalkthroughVersion bumps and changelog updates across nebula, thirdweb, and wagmi-adapter packages, plus deletion of a changeset file associated with a thirdweb patch preventing incorrect widget onramp failures. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Suggested labels
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal). Please share your feedback with us on this Discord post. Comment |
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
packages/wagmi-adapter/CHANGELOG.md (1)
3-4
: Add a brief note under 0.2.145 for clarity.Keeps the log useful during audits.
Apply this minimal addition:
## 0.2.145 + +### Patch Changes + +- Version bump only via Changesets; no code changes.packages/thirdweb/CHANGELOG.md (1)
3-8
: Changelog phrasing: switch to imperative mood and clarify noun orderTo match the prevailing style (“Fix …”, “Add …”), consider rewording the bullet and improving clarity.
- - [#8052](https://github.com/thirdweb-dev/js/pull/8052) [`557f0e2`](https://github.com/thirdweb-dev/js/commit/557f0e29e86d2ef3e3b72988f714203b4ede1009) Thanks [@gregfromstl](https://github.com/gregfromstl)! - Prevents incorrect failures in widget onramps. + - [#8052](https://github.com/thirdweb-dev/js/pull/8052) [`557f0e2`](https://github.com/thirdweb-dev/js/commit/557f0e29e86d2ef3e3b72988f714203b4ede1009) Thanks [@gregfromstl](https://github.com/gregfromstl)! - Prevent incorrect failure states in onramp widgets.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (7)
.changeset/floppy-clocks-wave.md
(0 hunks)packages/nebula/CHANGELOG.md
(1 hunks)packages/nebula/package.json
(1 hunks)packages/thirdweb/CHANGELOG.md
(1 hunks)packages/thirdweb/package.json
(1 hunks)packages/wagmi-adapter/CHANGELOG.md
(1 hunks)packages/wagmi-adapter/package.json
(1 hunks)
💤 Files with no reviewable changes (1)
- .changeset/floppy-clocks-wave.md
🧰 Additional context used
📓 Path-based instructions (2)
**/package.json
📄 CodeRabbit inference engine (AGENTS.md)
Track bundle budgets via
package.json#size-limit
Files:
packages/thirdweb/package.json
packages/nebula/package.json
packages/wagmi-adapter/package.json
packages/wagmi-adapter/**
📄 CodeRabbit inference engine (CLAUDE.md)
Wagmi ecosystem integration is in
packages/wagmi-adapter/
Files:
packages/wagmi-adapter/package.json
packages/wagmi-adapter/CHANGELOG.md
🧠 Learnings (2)
📚 Learning: 2025-08-29T15:37:38.513Z
Learnt from: CR
PR: thirdweb-dev/js#0
File: AGENTS.md:0-0
Timestamp: 2025-08-29T15:37:38.513Z
Learning: Applies to .changeset/*.md : Version bump rules: patch for non‑API changes; minor for new/modified public API
Applied to files:
packages/nebula/CHANGELOG.md
📚 Learning: 2025-07-18T19:19:55.613Z
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to packages/wagmi-adapter/** : Wagmi ecosystem integration is in `packages/wagmi-adapter/`
Applied to files:
packages/wagmi-adapter/package.json
packages/wagmi-adapter/CHANGELOG.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
- GitHub Check: E2E Tests (pnpm, vite)
- GitHub Check: Unit Tests
- GitHub Check: Size
- GitHub Check: Lint Packages
- GitHub Check: Analyze (javascript)
🔇 Additional comments (4)
packages/thirdweb/package.json (1)
420-421
: Patch version bump looks correct; proceed with publish.No other changes detected.
Per guidelines, ensure bundle budgets are tracked via package.json "size-limit". I see a "size" script, but no explicit "size-limit" config in this file—confirm budgets live here or centrally.
packages/nebula/package.json (1)
60-61
: Nebula patch bump aligns with dependency update to [email protected].Looks good.
Confirm whether Nebula also tracks bundle size (package.json "size-limit"); if not and this package ships code, consider adding it.
packages/wagmi-adapter/package.json (1)
58-60
: wagmi-adapter patch bump is fine; peer range already covers thirdweb 5.105.x.No additional action needed.
If this package is user-facing, consider adding/validating a "size-limit" budget per guidelines.
packages/nebula/CHANGELOG.md (1)
3-9
: Changelog entry is consistent with the version bump and links the source commit.All good.
size-limit report 📦
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8053 +/- ##
==========================================
- Coverage 56.53% 56.51% -0.02%
==========================================
Files 904 904
Lines 58865 58865
Branches 4166 4170 +4
==========================================
- Hits 33280 33269 -11
- Misses 25479 25491 +12
+ Partials 106 105 -1
🚀 New features to boost your workflow:
|
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
@thirdweb-dev/[email protected]
Patch Changes
557f0e2
]:[email protected]
Patch Changes
557f0e2
Thanks @gregfromstl! - Prevents incorrect failures in widget onramps.@thirdweb-dev/[email protected]
PR-Codex overview
This PR primarily focuses on updating version numbers across several packages and adding new changelog entries for
thirdweb
,nebula
, andwagmi-adapter
.Detailed summary
.changeset/floppy-clocks-wave.md
version
inpackages/thirdweb/package.json
from5.105.47
to5.105.48
version
inpackages/nebula/package.json
from0.2.47
to0.2.48
version
inpackages/wagmi-adapter/package.json
from0.2.144
to0.2.145
nebula
version0.2.48
thirdweb
version5.105.48
Summary by CodeRabbit
Bug Fixes
Chores