Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Sep 15, 2025

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.

Releases

@thirdweb-dev/[email protected]

Patch Changes

[email protected]

Patch Changes

@thirdweb-dev/[email protected]


PR-Codex overview

This PR primarily focuses on updating version numbers across several packages and adding new changelog entries for thirdweb, nebula, and wagmi-adapter.

Detailed summary

  • Deleted file: .changeset/floppy-clocks-wave.md
  • Updated version in packages/thirdweb/package.json from 5.105.47 to 5.105.48
  • Updated version in packages/nebula/package.json from 0.2.47 to 0.2.48
  • Updated version in packages/wagmi-adapter/package.json from 0.2.144 to 0.2.145
  • Added changelog entry for nebula version 0.2.48
  • Added changelog entry for thirdweb version 5.105.48

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Summary by CodeRabbit

  • Bug Fixes

    • Improved reliability of the onramp widget, preventing incorrect failure states and reducing false negatives during checkout.
  • Chores

    • Updated package versions (thirdweb, nebula, wagmi-adapter) with corresponding changelog entries.
    • No changes to public APIs or behavior outside the bug fix.

@joaquim-verges joaquim-verges requested review from a team as code owners September 15, 2025 17:08
Copy link

vercel bot commented Sep 15, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
docs-v2 Ready Ready Preview Comment Sep 15, 2025 5:42pm
nebula Ready Ready Preview Comment Sep 15, 2025 5:42pm
thirdweb_playground Ready Ready Preview Comment Sep 15, 2025 5:42pm
thirdweb-www Building Building Sep 15, 2025 5:42pm
wallet-ui Ready Ready Preview Comment Sep 15, 2025 5:42pm

Copy link
Contributor

coderabbitai bot commented Sep 15, 2025

Walkthrough

Version bumps and changelog updates across nebula, thirdweb, and wagmi-adapter packages, plus deletion of a changeset file associated with a thirdweb patch preventing incorrect widget onramp failures.

Changes

Cohort / File(s) Summary
Deleted changeset
./.changeset/floppy-clocks-wave.md
Removed changeset file that described a patch for thirdweb to prevent incorrect widget onramp failures.
Changelog updates
packages/nebula/CHANGELOG.md, packages/thirdweb/CHANGELOG.md, packages/wagmi-adapter/CHANGELOG.md
Added entries: nebula 0.2.48 (notes dependency update to [email protected]), thirdweb 5.105.48 (patch note about preventing incorrect widget onramp failures), wagmi-adapter 0.2.145 (header only).
Version bumps
packages/nebula/package.json, packages/thirdweb/package.json, packages/wagmi-adapter/package.json
Bumped versions: nebula 0.2.47 → 0.2.48, thirdweb 5.105.47 → 5.105.48, wagmi-adapter 0.2.144 → 0.2.145. No other fields changed.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested labels

packages, SDK

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The PR description includes autogenerated release notes and a PR-Codex summary that list the package bumps, but it does not follow the repository's required description template because it omits the "Notes for the reviewer" and "How to test" sections and does not include an issue tag or the requested title format; these omissions mean reviewer guidance and explicit test steps are missing. Add the missing template sections: include a "Notes for the reviewer" that states this is an automated changesets release (and any special considerations), and a "How to test" section with concrete validation steps (e.g., run unit tests, build, or verify CI/publishing behavior); also include the issue tag or update the PR title to match the repository's required format.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The title "Version Packages" is directly related to the primary change in this PR—bumping package versions and adding changelog entries across multiple packages—so it accurately summarizes the main intent in a concise way; it is somewhat generic but still informative for a quick scan.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch changeset-release/main

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

  • Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
  • Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.


Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added packages SDK Involves changes to the thirdweb SDK labels Sep 15, 2025
Copy link
Contributor

graphite-app bot commented Sep 15, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (2)
packages/wagmi-adapter/CHANGELOG.md (1)

3-4: Add a brief note under 0.2.145 for clarity.

Keeps the log useful during audits.

Apply this minimal addition:

 ## 0.2.145
+
+### Patch Changes
+
+- Version bump only via Changesets; no code changes.
packages/thirdweb/CHANGELOG.md (1)

3-8: Changelog phrasing: switch to imperative mood and clarify noun order

To match the prevailing style (“Fix …”, “Add …”), consider rewording the bullet and improving clarity.

- - [#8052](https://github.com/thirdweb-dev/js/pull/8052) [`557f0e2`](https://github.com/thirdweb-dev/js/commit/557f0e29e86d2ef3e3b72988f714203b4ede1009) Thanks [@gregfromstl](https://github.com/gregfromstl)! - Prevents incorrect failures in widget onramps.
+ - [#8052](https://github.com/thirdweb-dev/js/pull/8052) [`557f0e2`](https://github.com/thirdweb-dev/js/commit/557f0e29e86d2ef3e3b72988f714203b4ede1009) Thanks [@gregfromstl](https://github.com/gregfromstl)! - Prevent incorrect failure states in onramp widgets.
📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 557f0e2 and babef9b.

📒 Files selected for processing (7)
  • .changeset/floppy-clocks-wave.md (0 hunks)
  • packages/nebula/CHANGELOG.md (1 hunks)
  • packages/nebula/package.json (1 hunks)
  • packages/thirdweb/CHANGELOG.md (1 hunks)
  • packages/thirdweb/package.json (1 hunks)
  • packages/wagmi-adapter/CHANGELOG.md (1 hunks)
  • packages/wagmi-adapter/package.json (1 hunks)
💤 Files with no reviewable changes (1)
  • .changeset/floppy-clocks-wave.md
🧰 Additional context used
📓 Path-based instructions (2)
**/package.json

📄 CodeRabbit inference engine (AGENTS.md)

Track bundle budgets via package.json#size-limit

Files:

  • packages/thirdweb/package.json
  • packages/nebula/package.json
  • packages/wagmi-adapter/package.json
packages/wagmi-adapter/**

📄 CodeRabbit inference engine (CLAUDE.md)

Wagmi ecosystem integration is in packages/wagmi-adapter/

Files:

  • packages/wagmi-adapter/package.json
  • packages/wagmi-adapter/CHANGELOG.md
🧠 Learnings (2)
📚 Learning: 2025-08-29T15:37:38.513Z
Learnt from: CR
PR: thirdweb-dev/js#0
File: AGENTS.md:0-0
Timestamp: 2025-08-29T15:37:38.513Z
Learning: Applies to .changeset/*.md : Version bump rules: patch for non‑API changes; minor for new/modified public API

Applied to files:

  • packages/nebula/CHANGELOG.md
📚 Learning: 2025-07-18T19:19:55.613Z
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to packages/wagmi-adapter/** : Wagmi ecosystem integration is in `packages/wagmi-adapter/`

Applied to files:

  • packages/wagmi-adapter/package.json
  • packages/wagmi-adapter/CHANGELOG.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
  • GitHub Check: E2E Tests (pnpm, vite)
  • GitHub Check: Unit Tests
  • GitHub Check: Size
  • GitHub Check: Lint Packages
  • GitHub Check: Analyze (javascript)
🔇 Additional comments (4)
packages/thirdweb/package.json (1)

420-421: Patch version bump looks correct; proceed with publish.

No other changes detected.

Per guidelines, ensure bundle budgets are tracked via package.json "size-limit". I see a "size" script, but no explicit "size-limit" config in this file—confirm budgets live here or centrally.

packages/nebula/package.json (1)

60-61: Nebula patch bump aligns with dependency update to [email protected].

Looks good.

Confirm whether Nebula also tracks bundle size (package.json "size-limit"); if not and this package ships code, consider adding it.

packages/wagmi-adapter/package.json (1)

58-60: wagmi-adapter patch bump is fine; peer range already covers thirdweb 5.105.x.

No additional action needed.

If this package is user-facing, consider adding/validating a "size-limit" budget per guidelines.

packages/nebula/CHANGELOG.md (1)

3-9: Changelog entry is consistent with the version bump and links the source commit.

All good.

Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 63.96 KB (0%) 1.3 s (0%) 193 ms (+107.78% 🔺) 1.5 s
thirdweb (cjs) 361.44 KB (0%) 7.3 s (0%) 810 ms (+11.05% 🔺) 8.1 s
thirdweb (minimal + tree-shaking) 5.73 KB (0%) 115 ms (0%) 71 ms (+1178.16% 🔺) 186 ms
thirdweb/chains (tree-shaking) 526 B (0%) 11 ms (0%) 46 ms (+1958.64% 🔺) 56 ms
thirdweb/react (minimal + tree-shaking) 19.15 KB (0%) 383 ms (0%) 102 ms (+2445.6% 🔺) 484 ms

Copy link

codecov bot commented Sep 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.51%. Comparing base (557f0e2) to head (babef9b).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8053      +/-   ##
==========================================
- Coverage   56.53%   56.51%   -0.02%     
==========================================
  Files         904      904              
  Lines       58865    58865              
  Branches     4166     4170       +4     
==========================================
- Hits        33280    33269      -11     
- Misses      25479    25491      +12     
+ Partials      106      105       -1     
Flag Coverage Δ
packages 56.51% <ø> (-0.02%) ⬇️
see 4 files with indirect coverage changes
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages SDK Involves changes to the thirdweb SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants