Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

MananTank
Copy link
Member

@MananTank MananTank commented Sep 19, 2025


PR-Codex overview

This PR focuses on updating the route configurations in the next.config.mjs file to support dynamic path segments for specific routes.

Detailed summary

  • Updated the source for /insight to /insight/:path* to allow dynamic paths.
  • Updated the source for /payments/backend to /payments/backend/:path* to allow dynamic paths.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Summary by CodeRabbit

  • Bug Fixes
    • Fixed redirects for /insight and /payments/backend to handle nested paths, ensuring deep links (e.g., subpages) correctly route to their destinations without 404s.
    • Maintains existing base redirects and leaves other routes untouched, improving navigation reliability without altering overall site behavior.

Copy link

vercel bot commented Sep 19, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
thirdweb_playground Ready Ready Preview Comment Sep 20, 2025 1:37am
4 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
docs-v2 Skipped Skipped Sep 20, 2025 1:37am
nebula Skipped Skipped Sep 20, 2025 1:37am
thirdweb-www Skipped Skipped Sep 20, 2025 1:37am
wallet-ui Skipped Skipped Sep 20, 2025 1:37am

@vercel vercel bot temporarily deployed to Preview – thirdweb-www September 19, 2025 23:38 Inactive
@vercel vercel bot temporarily deployed to Preview – nebula September 19, 2025 23:38 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui September 19, 2025 23:38 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 September 19, 2025 23:38 Inactive
Copy link

changeset-bot bot commented Sep 19, 2025

⚠️ No Changeset found

Latest commit: 96ebf37

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

coderabbitai bot commented Sep 19, 2025

Walkthrough

Updated two Next.js redirect sources in apps/playground-web/next.config.mjs to include catch-all segments for nested paths. Destinations, permanence, and other configuration remain unchanged.

Changes

Cohort / File(s) Summary
Next.js redirects
apps/playground-web/next.config.mjs
Updated redirect sources: /insight/insight/:path*, /payments/backend/payments/backend/:path*. Destinations unchanged (https://insight.thirdweb.com/reference, /reference#tag/payments). permanent: false. No other config changes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The PR description contains the repository template comments and a PR-Codex autogenerated summary that documents the routing changes, but it does not fill the required template fields. Required sections such as the formatted PR title, the issue/Linear tag, "Notes for the reviewer", and explicit "How to test" steps remain as template comments and are therefore incomplete. Because these required template fields are not populated, the description does not meet the repository's description requirements. Please populate the repository PR template by replacing the commented placeholders with a properly formatted title (e.g., "[SDK/Dashboard/Portal] Fix: ..."), include the issue/Linear tag if available, add a concise "Notes for the reviewer" calling out important behavioral impacts, and provide concrete "How to test" instructions (manual steps and any tests to run) so reviewers can validate the redirect behavior; once those fields are completed the description should pass this check.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The title "Playground: Redirect corrections" accurately and concisely summarizes the primary change of the PR — updating redirect patterns in the playground Next.js configuration. It is short, focused, and avoids noisy file lists or emojis, so a teammate scanning history would quickly understand the main intent. The title could optionally include a subsystem prefix or issue reference to match repository conventions, but it is clear and relevant as written.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch 09-20-playground_redirect_corrections

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 93f913c and 462e1e1.

📒 Files selected for processing (1)
  • apps/playground-web/next.config.mjs (1 hunks)
🧰 Additional context used
🧠 Learnings (3)
📓 Common learnings
Learnt from: CR
PR: thirdweb-dev/js#0
File: .cursor/rules/dashboard.mdc:0-0
Timestamp: 2025-07-18T19:20:32.530Z
Learning: Applies to dashboard/**/*.{ts,tsx} : Redirect logic using `redirect()` from `next/navigation`.
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to apps/{dashboard,playground-web}/**/*.{ts,tsx} : Use `NavLink` for internal navigation with automatic active states in dashboard and playground apps
Learnt from: MananTank
PR: thirdweb-dev/js#7984
File: apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/components/ProjectSidebarLayout.tsx:76-80
Timestamp: 2025-09-05T19:45:05.006Z
Learning: When verifying route existence for Next.js app router, search for the full nested path structure rather than using simple patterns. The AI summary often contains accurate information about file additions that should be referenced before running verification scripts.
Learnt from: MananTank
PR: thirdweb-dev/js#7285
File: apps/dashboard/src/app/(app)/(dashboard)/published-contract/components/uri-based-deploy.tsx:57-57
Timestamp: 2025-06-05T13:59:49.886Z
Learning: In the thirdweb dashboard Next.js app, when using loginRedirect() in server components, ensure to add a return statement after the redirect call to prevent further code execution and potential security issues.
📚 Learning: 2025-09-05T19:45:05.006Z
Learnt from: MananTank
PR: thirdweb-dev/js#7984
File: apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/components/ProjectSidebarLayout.tsx:76-80
Timestamp: 2025-09-05T19:45:05.006Z
Learning: When verifying route existence for Next.js app router, search for the full nested path structure rather than using simple patterns. The AI summary often contains accurate information about file additions that should be referenced before running verification scripts.

Applied to files:

  • apps/playground-web/next.config.mjs
📚 Learning: 2025-07-18T19:20:32.530Z
Learnt from: CR
PR: thirdweb-dev/js#0
File: .cursor/rules/dashboard.mdc:0-0
Timestamp: 2025-07-18T19:20:32.530Z
Learning: Applies to dashboard/**/*.{ts,tsx} : Redirect logic using `redirect()` from `next/navigation`.

Applied to files:

  • apps/playground-web/next.config.mjs
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: Size
  • GitHub Check: Analyze (javascript)
🔇 Additional comments (2)
apps/playground-web/next.config.mjs (2)

151-154: Confirm intent: catch‑all source drops subpaths for /insight

With source: "/insight/:path*", requests like /insight/foo/bar will redirect to https://insight.thirdweb.com/reference (subpaths are discarded). If you want to preserve subpaths, forward them:

-        destination: "https://insight.thirdweb.com/reference",
+        destination: "https://insight.thirdweb.com/reference/:path*",

156-159: Same note for /payments/backend catch‑all + hash

/payments/backend/:path* currently collapses all nested paths to /reference#tag/payments. If you meant to keep subpaths, forward them before the hash:

-        destination: "/reference#tag/payments",
+        destination: "/reference/:path*#tag/payments",

Warning

Review ran into problems

🔥 Problems

Errors were encountered while retrieving linked issues.

Errors (1)
  • TEAM-0000: Entity not found: Issue - Could not find referenced Issue.

Comment @coderabbitai help to get the list of available commands and usage tips.

@MananTank MananTank marked this pull request as ready for review September 19, 2025 23:38
@MananTank MananTank requested review from a team as code owners September 19, 2025 23:38
@github-actions github-actions bot added the Playground Changes involving the Playground codebase. label Sep 19, 2025
Copy link
Member Author

MananTank commented Sep 19, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

codecov bot commented Sep 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.33%. Comparing base (b7732d3) to head (96ebf37).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8087   +/-   ##
=======================================
  Coverage   56.33%   56.33%           
=======================================
  Files         906      906           
  Lines       59186    59186           
  Branches     4176     4176           
=======================================
  Hits        33345    33345           
  Misses      25736    25736           
  Partials      105      105           
Flag Coverage Δ
packages 56.33% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

github-actions bot commented Sep 19, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 64.07 KB (0%) 1.3 s (0%) 1.6 s (-0.74% 🔽) 2.9 s
thirdweb (cjs) 361.64 KB (0%) 7.3 s (0%) 14 s (+2.46% 🔺) 21.3 s
thirdweb (minimal + tree-shaking) 5.73 KB (0%) 115 ms (0%) 119 ms (+69.11% 🔺) 234 ms
thirdweb/chains (tree-shaking) 526 B (0%) 11 ms (0%) 69 ms (+43.09% 🔺) 80 ms
thirdweb/react (minimal + tree-shaking) 19.14 KB (0%) 383 ms (0%) 279 ms (+159.65% 🔺) 662 ms

Copy link
Contributor

graphite-app bot commented Sep 20, 2025

Merge activity

<!--

## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"

If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):

## Notes for the reviewer

Anything important to call out? Be sure to also clarify these in your comments.

## How to test

Unit tests, playground, etc.

-->

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on updating the routing configuration in the `next.config.mjs` file to allow for dynamic path segments in specific routes.

### Detailed summary
- Changed `source` for `/insight` to `/insight/:path*`, allowing for dynamic paths.
- Changed `source` for `/payments/backend` to `/payments/backend/:path*`, enabling dynamic path handling.
- Both routes maintain their respective `destination` and `permanent` settings.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->

<!-- This is an auto-generated comment: release notes by coderabbit.ai -->

## Summary by CodeRabbit

* **Bug Fixes**
  * Fixed redirects for /insight and /payments/backend to handle nested paths, ensuring deep links (e.g., subpages) correctly route to their destinations without 404s.
  * Maintains existing base redirects and leaves other routes untouched, improving navigation reliability without altering overall site behavior.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
@graphite-app graphite-app bot force-pushed the 09-20-playground_redirect_corrections branch from 462e1e1 to 96ebf37 Compare September 20, 2025 01:10
@vercel vercel bot temporarily deployed to Preview – nebula September 20, 2025 01:10 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www September 20, 2025 01:10 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 September 20, 2025 01:10 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui September 20, 2025 01:10 Inactive
@graphite-app graphite-app bot merged commit 96ebf37 into main Sep 20, 2025
24 checks passed
@graphite-app graphite-app bot deleted the 09-20-playground_redirect_corrections branch September 20, 2025 01:38
@vercel vercel bot temporarily deployed to Production – wallet-ui September 20, 2025 01:38 Inactive
@vercel vercel bot temporarily deployed to Production – nebula September 20, 2025 01:38 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb-www September 20, 2025 01:38 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Playground Changes involving the Playground codebase.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants