Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Remove taint from GROWTH_PLAN_SKU and PAYMENT_METHOD_CONFIGURATION #8089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 20, 2025
Merged

Remove taint from GROWTH_PLAN_SKU and PAYMENT_METHOD_CONFIGURATION #8089

merged 1 commit into from
Sep 20, 2025

Conversation

jnsdls
Copy link
Member

@jnsdls jnsdls commented Sep 20, 2025 •
edited by coderabbitai bot
Loading

Temporarily removed tainting of GROWTH_PLAN_SKU and PAYMENT_METHOD_CONFIGURATION environment variables to allow client-side access. Added a comment to indicate these values should not be tainted for now.

Summary by CodeRabbit

  • Chores
    • Updated server-side environment configuration handling to streamline processing.
    • Removed redundant safeguards that are no longer needed in current workflows.
    • Clarified internal comments to reflect the latest handling approach.
    • No user-facing changes; functionality and UI remain unaffected.

@vercel Vercel
Copy link

vercel bot commented Sep 20, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
thirdweb-www Ready Ready Preview Comment Sep 20, 2025 2:07am
4 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
docs-v2 Skipped Skipped Sep 20, 2025 2:07am
nebula Skipped Skipped Sep 20, 2025 2:07am
thirdweb_playground Skipped Skipped Sep 20, 2025 2:07am
wallet-ui Skipped Skipped Sep 20, 2025 2:07am

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground September 20, 2025 01:58 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui September 20, 2025 01:58 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 September 20, 2025 01:58 Inactive
@vercel vercel bot temporarily deployed to Preview – nebula September 20, 2025 01:58 Inactive
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 20, 2025

⚠️ No Changeset found

Latest commit: df3897a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 20, 2025 •
edited
Loading

Caution

Review failed

The pull request is closed.

Walkthrough

Removed taintUniqueValue calls for GROWTH_PLAN_SKU and PAYMENT_METHOD_CONFIGURATION in apps/dashboard/src/@/constants/server-envs.ts, leaving exports unchanged and adding a comment to not taint these values.

Changes

Cohort / File(s) Summary of Changes
Server env tainting adjustments
apps/dashboard/src/@/constants/server-envs.ts		 Deleted taintUniqueValue calls for GROWTH_PLAN_SKU and PAYMENT_METHOD_CONFIGURATION; added comment "DO NOT TAINT THESE VALUES (for now)"; no changes to exports.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

✨ Finishing touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch Remove_taint_from_GROWTH_PLAN_SKU_and_PAYMENT_METHOD_CONFIGURATION
📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 96ebf37 and df3897a.

📒 Files selected for processing (1)
  • apps/dashboard/src/@/constants/server-envs.ts (1 hunks)

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Sep 20, 2025
@jnsdls Graphite App
Copy link
Member Author

jnsdls commented Sep 20, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@jnsdls jnsdls marked this pull request as ready for review September 20, 2025 01:58
@jnsdls jnsdls requested review from a team as code owners September 20, 2025 01:58
@jnsdls jnsdls merged commit 1338a0c into main Sep 20, 2025
21 of 23 checks passed
@jnsdls jnsdls deleted the Remove_taint_from_GROWTH_PLAN_SKU_and_PAYMENT_METHOD_CONFIGURATION branch September 20, 2025 01:58
@codecov Codecov
Copy link

codecov bot commented Sep 20, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.33%. Comparing base (1d90437) to head (df3897a).
⚠️ Report is 14 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #8089      +/-   ##
==========================================
- Coverage   56.34%   56.33%   -0.02%     
==========================================
  Files         906      906              
  Lines       59168    59186      +18     
  Branches     4176     4176              
==========================================
+ Hits        33341    33345       +4     
- Misses      25721    25736      +15     
+ Partials      106      105       -1
Flag Coverage Δ
packages 56.33% <ø> (-0.02%) ⬇️
see 7 files with indirect coverage changes
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions GitHub Actions
Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 64.07 KB (0%) 1.3 s (0%) 243 ms (+137.79% 🔺) 1.6 s
thirdweb (cjs) 361.64 KB (0%) 7.3 s (0%) 1.1 s (+10.18% 🔺) 8.3 s
thirdweb (minimal + tree-shaking) 5.73 KB (0%) 115 ms (0%) 101 ms (+1564.16% 🔺) 215 ms
thirdweb/chains (tree-shaking) 526 B (0%) 11 ms (0%) 88 ms (+1140.88% 🔺) 98 ms
thirdweb/react (minimal + tree-shaking) 19.14 KB (0%) 383 ms (0%) 130 ms (+2109.12% 🔺) 513 ms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jnsdls jnsdls

Labels
Dashboard Involves changes to the Dashboard.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jnsdls