-
Notifications
You must be signed in to change notification settings - Fork 589
Version Packages #8110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version Packages #8110
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub.
|
WalkthroughRemoved a changeset entry related to thirdweb. Bumped versions and updated changelogs for packages: nebula (0.2.54), thirdweb (5.108.1), and wagmi-adapter (0.2.151). Documented thirdweb patch note about BuyWidget failure error messages in its changelog. No code or public API changes. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested labels
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests
Comment |
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
packages/thirdweb/package.json (1)
430-431
: Version bump looks good — confirm/move size-limit into package.jsonFound bundle budget at packages/thirdweb/.size-limit.json; packages/thirdweb/package.json has no "size-limit" field (it has a "size" script). Move the config into package.json#size-limit per guideline or confirm keeping the standalone file.
packages/thirdweb/CHANGELOG.md (1)
7-7
: Polish wording for clarity and consistency"failure error messages" is redundant. Prefer a crisper phrasing.
- - [#8108](https://github.com/thirdweb-dev/js/pull/8108) [`e1cccd7`](https://github.com/thirdweb-dev/js/commit/e1cccd7a10447943c4b31f34e09a94d2ff5ee826) Thanks [@gregfromstl](https://github.com/gregfromstl)! - Displays the failure error messages on the BuyWidget + - [#8108](https://github.com/thirdweb-dev/js/pull/8108) [`e1cccd7`](https://github.com/thirdweb-dev/js/commit/e1cccd7a10447943c4b31f34e09a94d2ff5ee826) Thanks [@gregfromstl](https://github.com/gregfromstl)! - Displays error messages for BuyWidget failures
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (7)
.changeset/wicked-cycles-attack.md
(0 hunks)packages/nebula/CHANGELOG.md
(1 hunks)packages/nebula/package.json
(1 hunks)packages/thirdweb/CHANGELOG.md
(1 hunks)packages/thirdweb/package.json
(1 hunks)packages/wagmi-adapter/CHANGELOG.md
(1 hunks)packages/wagmi-adapter/package.json
(1 hunks)
💤 Files with no reviewable changes (1)
- .changeset/wicked-cycles-attack.md
🧰 Additional context used
📓 Path-based instructions (2)
packages/wagmi-adapter/**
📄 CodeRabbit inference engine (CLAUDE.md)
Wagmi ecosystem integration is in
packages/wagmi-adapter/
Files:
packages/wagmi-adapter/package.json
packages/wagmi-adapter/CHANGELOG.md
**/package.json
📄 CodeRabbit inference engine (AGENTS.md)
Track bundle budgets via
package.json#size-limit
Files:
packages/wagmi-adapter/package.json
packages/nebula/package.json
packages/thirdweb/package.json
🧠 Learnings (2)
📚 Learning: 2025-08-29T15:37:38.513Z
Learnt from: CR
PR: thirdweb-dev/js#0
File: AGENTS.md:0-0
Timestamp: 2025-08-29T15:37:38.513Z
Learning: Applies to .changeset/*.md : Version bump rules: patch for non‑API changes; minor for new/modified public API
Applied to files:
packages/nebula/CHANGELOG.md
📚 Learning: 2025-07-18T19:19:55.613Z
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to packages/wagmi-adapter/** : Wagmi ecosystem integration is in `packages/wagmi-adapter/`
Applied to files:
packages/wagmi-adapter/package.json
packages/wagmi-adapter/CHANGELOG.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)
- GitHub Check: Build Packages
- GitHub Check: E2E Tests (pnpm, vite)
- GitHub Check: E2E Tests (pnpm, esbuild)
- GitHub Check: Unit Tests
- GitHub Check: Size
- GitHub Check: E2E Tests (pnpm, webpack)
- GitHub Check: Lint Packages
- GitHub Check: Analyze (javascript)
🔇 Additional comments (6)
packages/nebula/package.json (1)
60-61
: Nebula version bump OK.No dependency/peer changes; aligns with changelog.
Confirm whether this package intentionally omits a size-limit budget, or add package.json#size-limit per guideline if applicable.
packages/wagmi-adapter/package.json (1)
58-59
: Wagmi adapter version bump OK; peer ranges remain compatible.thirdweb ^5.85.0 covers 5.108.1.
If this package ships browser code, consider tracking a size-limit budget in package.json as per guideline (or confirm it’s covered elsewhere).
packages/wagmi-adapter/CHANGELOG.md (1)
3-4
: Changelog entry added correctly.Header aligns with package.json version.
packages/thirdweb/CHANGELOG.md (1)
3-8
: LGTM for the new 5.108.1 entryVersion section is correctly added at the top with appropriate links and formatting.
packages/nebula/CHANGELOG.md (2)
3-9
: Changelog entry looks good for a patch bump.Consistent heading levels; dependency update and commit link are clear.
7-9
: Verified — thirdweb 5.108.1 present; Nebula uses workspace dependencypackages/nebula/package.json depends on thirdweb as "workspace:" (not explicitly pinned to 5.108.1); packages/thirdweb/package.json is 5.108.1 and packages/thirdweb/CHANGELOG.md contains the 5.108.1 entry. No action required unless you want Nebula to pin thirdweb to 5.108.1 instead of using workspace:.
size-limit report 📦
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8110 +/- ##
=======================================
Coverage 56.31% 56.32%
=======================================
Files 906 906
Lines 59206 59206
Branches 4176 4179 +3
=======================================
+ Hits 33340 33345 +5
+ Misses 25760 25755 -5
Partials 106 106
🚀 New features to boost your workflow:
|
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
@thirdweb-dev/[email protected]
Patch Changes
e1cccd7
]:[email protected]
Patch Changes
e1cccd7
Thanks @gregfromstl! - Displays the failure error messages on the BuyWidget@thirdweb-dev/[email protected]
PR-Codex overview
This PR focuses on version updates for several packages, including
thirdweb
,nebula
, andwagmi-adapter
, along with corresponding changelog entries for the new versions.Detailed summary
version
inpackages/thirdweb/package.json
from5.108.0
to5.108.1
version
inpackages/nebula/package.json
from0.2.53
to0.2.54
version
inpackages/wagmi-adapter/package.json
from0.2.150
to0.2.151
nebula
version0.2.54
noting dependency updatesthirdweb
version5.108.1
detailing a fix for theBuyWidget
error messagesSummary by CodeRabbit
Bug Fixes
Chores