Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Update padds.py#251

Merged
thouska merged 1 commit into
thouska:masterfrom
Jinadelee:patch-1
Sep 1, 2020
Merged

Update padds.py#251
thouska merged 1 commit into
thouska:masterfrom
Jinadelee:patch-1

Conversation

@Jinadelee

Copy link
Copy Markdown
Contributor

This will ensure new_value within the predefined min and max bounds

This will ensure new_value within the predefined min and max bounds
@coveralls

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 842

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.07%) to 89.941%

Files with Coverage Reduction New Missed Lines %
spotpy/algorithms/rope.py 1 93.58%
spotpy/algorithms/sceua.py 2 88.79%
Totals Coverage Status
Change from base Build 836: -0.07%
Covered Lines: 4131
Relevant Lines: 4593

💛 - Coveralls

@thouska

thouska commented Sep 1, 2020

Copy link
Copy Markdown
Owner

Hi @Jinadelee,
thanks for the contribution, this was indeed an error. Thx for the fix.
Please note that, you might face other unresolved errors in padds as it is in a early beta testing-phase in spotpy, so it is, different to the other implemented algorithms, currently not ready for production use. However, your valueable contribution brings us closer to the goal of having padds robustly implemented.

@thouska thouska merged commit 72f4eb0 into thouska:master Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants