Make sure to set max connection to 1 #45
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If one or more files fail to pack, the entire process will end up in an error in the end. It will also print out all failed files
db975e8 to
7b324e9
Compare
This was referenced Apr 8, 2024
steveej
approved these changes
Apr 8, 2024
Contributor
steveej
left a comment
There was a problem hiding this comment.
i can confirm this work in my use-case of pack'ing a nixos rootfs to s3 on a machine with many cores.
please see the code readability suggestion i made as well.
thank you!
|
|
||
| let pool = SqlitePool::connect_with(opts).await?; | ||
| let pool = SqlitePoolOptions::new() | ||
| .max_connections(1) |
Contributor
There was a problem hiding this comment.
since there is already an explicit opts variable it's slightly confusing to see this option added here instead of adding it to opts.
Comment on lines
+351
to
+354
| let pool = SqlitePoolOptions::new() | ||
| .max_connections(1) | ||
| .connect_with(opts) | ||
| .await?; |
Contributor
There was a problem hiding this comment.
Suggested change
| let pool = SqlitePoolOptions::new() | |
| .max_connections(1) | |
| .connect_with(opts) | |
| .await?; | |
| let pool = SqlitePool::connect_with(opts).await?; |
| @@ -348,7 +348,10 @@ impl Writer { | |||
| .journal_mode(SqliteJournalMode::Delete) | |||
Contributor
There was a problem hiding this comment.
Suggested change
| .journal_mode(SqliteJournalMode::Delete) | |
| .journal_mode(SqliteJournalMode::Delete) | |
| .max_connections(1) |
this introduces a single source of truth for the used rust toolchain
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.