feat: improve TextParser error handling#1061
Open
jpogorzelski wants to merge 1 commit intothymeleaf:3.1-masterfrom
Open
feat: improve TextParser error handling#1061jpogorzelski wants to merge 1 commit intothymeleaf:3.1-masterfrom
jpogorzelski wants to merge 1 commit intothymeleaf:3.1-masterfrom
Conversation
catch TemplateProcessingException that may contain line and column information before fallback to generic Exception
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The purpose of this change in
TextParser::parseDocumentmethod is to catchTemplateProcessingExceptionbefore fallback to generic Exception class in.TemplateProcessingExceptionmay contain line and column information in its fields, which is easy to access when handling parsing errors.I stumbled upon this scenario, when building custom validator for end user defined templates in web based editor. In this case, it is important to have line and column where template has errors.
Currently, TextParser looses this information when catching generic Exception.
Currently, Thymeleaf contains 3 exception classes that maintain
lineandcolinformation:TextParseException,RawParseExceptionandTemplateProcessingException.Another approach could be introducing custom exception class dedicated for containing
lineandcolproperties that could be inherited by those 3 mentioned above, but it would need bigger refactoring.