Thanks to visit codestin.com
Credit goes to github.com

Skip to content

🌐 Add Japanese translation for docs/ja/docs/deployment/https.md#10298

Merged
tiangolo merged 5 commits into
fastapi:masterfrom
tamtam-fitness:add-https-documentation-in-jp
Sep 25, 2023
Merged

🌐 Add Japanese translation for docs/ja/docs/deployment/https.md#10298
tiangolo merged 5 commits into
fastapi:masterfrom
tamtam-fitness:add-https-documentation-in-jp

Conversation

@tamtam-fitness

@tamtam-fitness tamtam-fitness commented Sep 21, 2023

Copy link
Copy Markdown
Contributor

Add Japanese translation of About HTTPS

@tamtam-fitness tamtam-fitness changed the title 📝 add docs for https 🌐 Add Japanese translation for docs/ja/docs/deployment/https.md Sep 21, 2023
@tiangolo

Copy link
Copy Markdown
Member

📝 Docs preview for commit e6473b8 at: https://9d0eeb66.fastapitiangolo.pages.dev

@tamtam-fitness tamtam-fitness marked this pull request as ready for review September 21, 2023 03:19
@tamtam-fitness

Copy link
Copy Markdown
Contributor Author

https://9d0eeb66.fastapitiangolo.pages.dev/ja/deployment/https/
Here is the page I translated.

@tiangolo

Copy link
Copy Markdown
Member

📝 Docs preview for commit 92920ac at: https://9040a948.fastapitiangolo.pages.dev

@tiangolo tiangolo added lang-all Translations lang-ja Japanese translations awaiting-review labels Sep 22, 2023
Comment thread docs/ja/docs/deployment/https.md Outdated
!!! tip
もし急いでいたり、HTTPSの仕組みについて気にしないのであれば、次のセクションに進み、さまざまなテクニックを使ってすべてをセットアップするステップ・バイ・ステップの手順をご覧ください。

消費者の視点から **HTTPS の基本を学ぶ**に当たっては、次のリソースをオススメします: <a href="https://howhttps.works/" class="external-link" target="_blank">https://howhttps.works/</a>.

@bankofsardine bankofsardine Sep 23, 2023

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

全て素敵な文章でしたが、ここは「利用者」のほうが分かりやすいと思います("consumer" translated directly in Japanese may make it difficult to understand original meaning. But not bad translation.)

@tamtam-fitness tamtam-fitness Sep 24, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bankofsardine
Thx! I fixed it according to your point.
fab792b

@bankofsardine bankofsardine left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good to me.

@tamtam-fitness

Copy link
Copy Markdown
Contributor Author

@bankofsardine @Yum-git
Thank you for reviewing!

Could you re-review my latest commit?
fab792b

@tiangolo

Copy link
Copy Markdown
Member

📝 Docs preview for commit fab792b at: https://11b9edd9.fastapitiangolo.pages.dev

@tiangolo

Copy link
Copy Markdown
Member

Thank you @tamtam-fitness! 🚀

And thanks for the reviews @bankofsardine and @Yum-git! 🍰

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved-2 lang-all Translations lang-ja Japanese translations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants