🌐 Add Japanese translation for docs/ja/docs/tutorial/response-status-code.md#1942
Conversation
…/ryuckel/fastapi into feature/add-japanese-translation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #1942 +/- ##
===========================================
Coverage 100.00% 100.00%
===========================================
Files 540 239 -301
Lines 13969 7079 -6890
===========================================
- Hits 13969 7079 -6890 ☔ View full report in Codecov by Sentry. |
|
📝 Docs preview for commit 22f8861 at: https://5f3ff22c5c652e24b3592495--fastapi.netlify.app |
|
📝 Docs preview for commit 31a534e at: https://5f4cbf4e5bf93092ddad3227--fastapi.netlify.app |
Co-authored-by: T. Tokusumi <[email protected]>
Co-authored-by: T. Tokusumi <[email protected]>
Co-authored-by: T. Tokusumi <[email protected]>
Co-authored-by: T. Tokusumi <[email protected]>
Co-authored-by: T. Tokusumi <[email protected]>
Co-authored-by: T. Tokusumi <[email protected]>
Co-authored-by: T. Tokusumi <[email protected]>
Co-authored-by: T. Tokusumi <[email protected]>
Co-authored-by: T. Tokusumi <[email protected]>
…hub.com:SwftAlpc/fastapi into translation/ja-tutorial-response-status-code-md
Co-authored-by: T. Tokusumi <[email protected]>
|
@tokusumi |
|
📝 Docs preview for commit 2e95898 at: https://5f9aab908b8d8321f2fcef08--fastapi.netlify.app |
tokusumi
left a comment
There was a problem hiding this comment.
Thank you for accepting my suggestions🎉
delhi09
left a comment
There was a problem hiding this comment.
It looks mostly good.
I pointed out some details.
| * `@app.post()` | ||
| * `@app.put()` | ||
| * `@app.delete()` | ||
| * など。 |
There was a problem hiding this comment.
I feel it's a little unnatural for translating "etc" to "など" and I think it may be kept an English word "etc".
|
|
||
| つまり: | ||
|
|
||
| * `100`以上は「情報」のためのものです。。直接使うことはほとんどありません。これらのステータスコードを持つレスポンスはボディを持つことができません。 |
| {!../../../docs_src/response_status_code/tutorial002.py!} | ||
| ``` | ||
|
|
||
| それらは便利です。それらは同じ番号を保持しており、その方法ではエディタの自動補完を使用してそれらを見つけることができます。 |
There was a problem hiding this comment.
- It's better to modify "保持しており" to "保持していますが" because "but" is used as a conjunction in the original sentence.
- In my opinion, It's better to modify the first "それら" to "
fastapi.statusの変数" and "その方法" to "`それらの変数を使用する方法" because "それ" or "その" appears three times make the sentence a little difficult to read.
docs/ja/docs/tutorial/response-status-code.md
|
📝 Docs preview for commit afa65b7 at: https://6499caf4706d0c04fc5a1966--fastapi.netlify.app |
This PR translates the tutorial/response-status-code.md to Japanese.
Please review tutorial/response-status-code.md.
Issue #1571 generates a new directory to support Japanese.PR #1656 generates a new directory for tutorial.
I will fix dependency after #1571 & #1656 are merged.