Codestin Search App

JeongHyeongKim · 2021-02-18T05:19:20Z

related issue -> #2017
I'm Happy to contribute to this repository by translate eng to ko.
if have any error or suggestion in my pr, please comment to in this pr :)
thanks for reviewer

This PR translates tutorial/middleware.md in Korean.
related: #2017 @

codecov · 2021-02-18T05:21:02Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cf73051) 100.00% compared to head (d8bd0ec) 100.00%.
Report is 1238 commits behind head on master.

❗ Current head d8bd0ec differs from pull request most recent head 9e0718c. Consider uploading reports for the commit 9e0718c to get more accurate results

Additional details and impacted files

@@            Coverage Diff            @@
##            master     #2829   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          540       540           
  Lines        13969     13934   -35     
=========================================
- Hits         13969     13934   -35

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-actions · 2021-02-18T05:22:55Z

📝 Docs preview for commit 4c72d00 at: https://602df95ffc58236c636bbe5b--fastapi.netlify.app

github-actions · 2021-02-18T05:34:16Z

📝 Docs preview for commit a2ee84a at: https://602dfc29f05c9278bedee7d1--fastapi.netlify.app

hard-coders

Welcome aboard 🎉 , and thanks for your works!

However, I hope you refer to other Korean translation PRs.

JeongHyeongKim · 2021-02-28T21:19:33Z

thanks for your review @hard-coders
There are many mistranslation in this PR. Because this pr is first pr in my carrer. :)

I learn a lot at this PR :)

i will reflect all of your comment within 3days

github-actions · 2021-03-02T03:06:37Z

📝 Docs preview for commit b1d721f at: https://603dab8c9e0974360f0b7913--fastapi.netlify.app

github-actions · 2021-03-02T03:15:49Z

📝 Docs preview for commit 6bfb733 at: https://603dadb7792ea942f7dae553--fastapi.netlify.app

github-actions · 2021-03-02T04:42:09Z

📝 Docs preview for commit 0f2c891 at: https://603dc1ef73a63a63be3ec0a4--fastapi.netlify.app

JeongHyeongKim · 2021-05-11T00:23:09Z

@hard-coders
i accepted your reviews and modified this pr at 3/2
can i request re-review this pr?
thank you

hard-coders

I'm sorry for being late. Some feedback is here and you need to modify mkdocs.yml file.

And... resolve outdated reviews, please.

Co-authored-by: Spike <[email protected]>

JeongHyeongKim · 2021-05-11T08:28:55Z

i accepted your review :) thanks @hard-coders!
but i have some questionmark at above.

i think, we uaually use "request", "response" in english at our daily work.
so i suggest that the word "request", "response" use english in our translate contribution

hard-coders · 2021-05-11T08:52:42Z

@JeongHyeongKim
I sincerely understand what you mean, but I usually use "요청", "응답" in work. I'm not lying :)
By your logic, I also can claim we should use "요청". It's ambiguous. So we need a rule, official Python Korean docs.
In addition, backtick(`) is used to represent a code in markdown, however.

accept hard-coders rules Co-authored-by: Spike <[email protected]>

Co-authored-by: Spike <[email protected]>

JeongHyeongKim · 2021-05-11T09:16:09Z

thanks you for review this pr @hard-coders !
can i write a comment at #3167 about the rule that we talked today?
it can be a good reference to another contributer :)

0417taehyun

Big appreciate of your works and great honor to check it 🚀

Can you update this file to latest?

Please feel free to check my reviews!

JeongHyeongKim · 2021-11-08T00:15:46Z

Thanks for your review. I will check your review and apply soon.
@0417taehyun

Co-authored-by: weekwith.me <[email protected]>

JeongHyeongKim · 2021-12-09T02:42:40Z

@0417taehyun
your translation is better than my translation. i check your translation and accept your review :)
thank for your review

github-actions · 2022-09-23T02:03:24Z

📝 Docs preview for commit d8bd0ec at: https://632d13a9e36d8116f04e2148--fastapi.netlify.app

github-actions · 2022-12-16T19:54:33Z

📝 Docs preview for commit 2241794 at: https://639cccc5ed5882136dfea9e8--fastapi.netlify.app

tiangolo · 2023-06-26T22:48:23Z

📝 Docs preview for commit 9e0718c at: https://649a1585acd72b10c561eaad--fastapi.netlify.app

alejsdev · 2024-01-31T14:35:31Z

Nice, thanks for the help! @JeongHyeongKim 🤓🚀

And thanks for the reviews @hard-coders @0417taehyun 🎉

Add Korean Translation for Tutorial - Middleware

4c72d00

update some words

a2ee84a

hard-coders reviewed Feb 28, 2021

View reviewed changes

JeongHyeongKim added 2 commits March 2, 2021 11:59

apply feedback

8ebda36

apply feedback

b1d721f

remove term '당신'

6bfb733

modity format to en

0f2c891

tiangolo added awaiting-review lang-all Translations lang-ko Korean translations labels Mar 27, 2021

tiangolo changed the title ~~🌐 Add Korean Translation for Tutorial - Middleware~~ 🌐 Add Korean translation for Tutorial - Middleware Mar 27, 2021

hard-coders suggested changes May 11, 2021

View reviewed changes

hard-coders mentioned this pull request May 11, 2021

Korean translations #2017

Closed

JeongHyeongKim and others added 4 commits May 11, 2021 17:11

Update docs/ko/docs/tutorial/middleware.md

6b31dc6

Co-authored-by: Spike <[email protected]>

Update docs/ko/docs/tutorial/middleware.md

1695e7f

Co-authored-by: Spike <[email protected]>

Update docs/ko/docs/tutorial/middleware.md

1efab28

Co-authored-by: Spike <[email protected]>

Merge branch 'master' into master

556dada

JeongHyeongKim and others added 2 commits May 11, 2021 18:12

Update docs/ko/docs/tutorial/middleware.md

7146aec

accept hard-coders rules Co-authored-by: Spike <[email protected]>

Update docs/ko/docs/tutorial/middleware.md

a892b90

Co-authored-by: Spike <[email protected]>

0417taehyun suggested changes Nov 3, 2021

View reviewed changes

JeongHyeongKim and others added 10 commits December 9, 2021 11:36

Update docs/ko/docs/tutorial/middleware.md

a77f979

Co-authored-by: weekwith.me <[email protected]>

Update docs/ko/docs/tutorial/middleware.md

be6aa46

Co-authored-by: weekwith.me <[email protected]>

Update docs/ko/docs/tutorial/middleware.md

dcd077d

Co-authored-by: weekwith.me <[email protected]>

Update docs/ko/docs/tutorial/middleware.md

4ca3ac7

Co-authored-by: weekwith.me <[email protected]>

Update docs/ko/docs/tutorial/middleware.md

02944dd

Co-authored-by: weekwith.me <[email protected]>

Update docs/ko/docs/tutorial/middleware.md

b5b09b7

Co-authored-by: weekwith.me <[email protected]>

Update docs/ko/docs/tutorial/middleware.md

470b1e6

Co-authored-by: weekwith.me <[email protected]>

Update docs/ko/docs/tutorial/middleware.md

1faa465

Co-authored-by: weekwith.me <[email protected]>

Update docs/ko/docs/tutorial/middleware.md

0d7f133

Co-authored-by: weekwith.me <[email protected]>

Update docs/ko/docs/tutorial/middleware.md

3c5bd36

Co-authored-by: weekwith.me <[email protected]>

JeongHyeongKim added 2 commits December 9, 2021 11:43

Merge branch 'master' into master

15fe78f

Update middleware.md

02f34f3

joonas-yoon added a commit to joonas-yoon/fastapi that referenced this pull request Aug 6, 2022

translated by fastapi#2829

2e7d567

Merge branch 'master' into master

d8bd0ec

Merge branch 'master' into master

2241794

Merge branch 'master' into master

9e0718c

tiangolo changed the title ~~🌐 Add Korean translation for Tutorial - Middleware~~ 🌐 Add Korean translation for docs/ko/docs/tutorial/middleware.md Jun 26, 2023

tiangolo added awaiting-review and removed awaiting-review labels Jun 26, 2023

JeongHyeongKim requested a review from 0417taehyun August 22, 2023 08:33

alejsdev added approved-1 and removed awaiting-review labels Jan 31, 2024

alejsdev merged commit 7178eb4 into fastapi:master Jan 31, 2024

Uh oh!

Conversation

JeongHyeongKim commented Feb 18, 2021

Uh oh!

codecov Bot commented Feb 18, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions Bot commented Feb 18, 2021

Uh oh!

github-actions Bot commented Feb 18, 2021

Uh oh!

hard-coders left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JeongHyeongKim commented Feb 28, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Mar 2, 2021

Uh oh!

github-actions Bot commented Mar 2, 2021

Uh oh!

github-actions Bot commented Mar 2, 2021

Uh oh!

JeongHyeongKim commented May 11, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hard-coders left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JeongHyeongKim commented May 11, 2021

Uh oh!

hard-coders commented May 11, 2021

Uh oh!

JeongHyeongKim commented May 11, 2021

Uh oh!

0417taehyun left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JeongHyeongKim commented Nov 8, 2021

Uh oh!

JeongHyeongKim commented Dec 9, 2021

Uh oh!

github-actions Bot commented Sep 23, 2022

Uh oh!

github-actions Bot commented Dec 16, 2022

Uh oh!

tiangolo commented Jun 26, 2023

Uh oh!

alejsdev commented Jan 31, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

codecov Bot commented Feb 18, 2021 •

edited

Loading

JeongHyeongKim commented Feb 28, 2021 •

edited

Loading

JeongHyeongKim commented May 11, 2021 •

edited

Loading

hard-coders left a comment •

edited

Loading

alejsdev commented Jan 31, 2024 •

edited

Loading