Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Vectorise replacement function #462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hadley merged 19 commits into from
Jul 16, 2024
Merged

Vectorise replacement function #462

hadley merged 19 commits into from
Jul 16, 2024

Conversation

@hadley
Copy link
Member

@hadley hadley commented Oct 4, 2022 •
edited
Loading

This breaks 7 revdeps but I think it's worth it because the performance improvement is immense.

@hadley hadley requested a review from DavisVaughan October 4, 2022 12:37
@hadley
Copy link
Member Author

hadley commented Oct 4, 2022

It also breaks rmarkdown 😬

Error in `if (grepl("^[.][.]", in_file)) ...`:
! the condition has length > 1
---
Backtrace:
     ▆
  1. └─pkgdown::build_article("from-base", new_process = FALSE)
  2.   └─pkgdown:::render_rmarkdown(...) at pkgdown/R/build-articles.R:281:2
  3.     ├─rlang::inject(rmarkdown::render(!!!args)) at pkgdown/R/rmarkdown.R:52:4
  4.     └─rmarkdown::render(...) at rlang/R/eval.R:195:2
  5.       └─output_format$post_processor(...)
  6.         └─rmarkdown (local) base(metadata, input_file, output_file, ...)
  7.           └─rmarkdown:::process_images(output_str, image_relative)
  8.             └─rmarkdown:::process_html_res(...)
  9.               └─stringr::str_replace_all(html, reg, process_img_src)
 10.                 └─stringr:::str_transform_all(string, pattern, replacement) at stringr/R/replace.r:91:4
 11.                   └─rmarkdown (local) replacement(old_flat) at stringr/R/replace.r:201:4
 12.                     └─rmarkdown (local) processor(img_src, src)

@hadley
Copy link
Member Author

hadley commented Oct 4, 2022

rmarkdown patch in rstudio/rmarkdown#2416. Breaking rmarkdown is a big deal, so I don't think we should merge this until after rmarkdown is released, so it probably won't make it for this release.

@hadley hadley force-pushed the vectorise-replace branch from 44d861e to 4767c88 Compare October 4, 2022 14:17
@cderv cderv mentioned this pull request Oct 4, 2022
Merged
@DavisVaughan
Copy link
Member

DavisVaughan commented Oct 4, 2022 •
edited
Loading

I guess pkgdown is failing because rmarkdown is broken? Very meta - ah yes i see that in your backtrace

DavisVaughan
DavisVaughan approved these changes Oct 4, 2022
View reviewed changes
Copy link
Member

@DavisVaughan DavisVaughan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the broken packages are like rmarkdown? They didn't expect multiple strings at once?

R/replace.R Outdated

# unchop list into a vector, apply replacement(), and then rechop back into
# a list
old_flat <- vctrs::vec_unchop(old, idx)
Copy link
Member

@DavisVaughan DavisVaughan Oct 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Depending on how much you value readability over performance, you don't actually need to pass idx here since you are unchopping in the order the input was provided

Copy link
Member Author

@hadley hadley Jan 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In dev vctrs:

xs <- list("a", c("b", "c"), c("d", "e", "f"))

x <- list_unchop(xs)
x <- toupper(x)
x
#> [1] "A" "B" "C" "D" "E" "F"

sizes <- list_sizes(xs)
vec_partition(x, sizes)

@hadley
Copy link
Member Author

hadley commented Oct 5, 2022

Yeah, the failures seem to be cases that expected a single string. So there's always a trivial fix, which is to vectorise with vapply() or similar. When I do the revdep fixes, I'll try and vectorise properly so they can benefit from the performance boost.

@hadley
Copy link
Member Author

hadley commented Oct 20, 2022

Fixed in rmarkdown 2.17, but I think this will have to wait until the next release since otherwise installing stringr will break older (i.e. most) rmarkdown installed.

hadley added 2 commits October 31, 2023 08:05
@hadley
Merge commit '8367482c727b2f014a944560dc2cbabd486ec761'
8d94ae6 
#Conflicts:
#	NEWS.md
#	R/replace.R
#	man/str_replace.Rd
#	revdep/README.md
#	revdep/cran.md
#	revdep/problems.md
#	tests/testthat/_snaps/replace.md
#	tests/testthat/test-replace.R
@hadley
Fix merge issues
432d7db
@hadley hadley added the breaking change ☠️ API change likely to affect existing code label Oct 31, 2023
@hadley
Copy link
Member Author

hadley commented Jul 16, 2024

I think enough time has elapsed that we can now merge this, fixing the 7 CRAN failures with PRs.

hadley
hadley commented Jul 16, 2024
View reviewed changes
@hadley hadley merged commit 5a96ff0 into main Jul 16, 2024
@hadley hadley deleted the vectorise-replace branch July 16, 2024 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DavisVaughan DavisVaughan DavisVaughan approved these changes

Assignees

No one assigned

Labels

breaking change ☠️ API change likely to affect existing code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hadley @DavisVaughan