[to #375] use scanRegions request to warm up client - #383
Merged
zz-jason merged 11 commits intoDec 24, 2021
Conversation
Signed-off-by: birdstorm <[email protected]>
Signed-off-by: birdstorm <[email protected]>
…storm/client-java into use-scan-regions-request-to-warm-up
Signed-off-by: birdstorm <[email protected]>
zz-jason
reviewed
Dec 13, 2021
zz-jason
reviewed
Dec 13, 2021
zz-jason
left a comment
Member
There was a problem hiding this comment.
could you add some test for this PR?
Signed-off-by: birdstorm <[email protected]>
Signed-off-by: birdstorm <[email protected]>
Signed-off-by: birdstorm <[email protected]>
zz-jason
reviewed
Dec 15, 2021
|
|
||
| private void doTest(TiConfiguration conf) throws Exception { | ||
| session = TiSession.create(conf); | ||
| long start = System.currentTimeMillis(); |
Member
There was a problem hiding this comment.
is it better to use System.nanoTime()?
Collaborator
Author
There was a problem hiding this comment.
I think it is not necessary in unit test.
zz-jason
reviewed
Dec 15, 2021
Comment on lines
+133
to
+135
| doTest(conf); | ||
| conf.setWarmUpEnable(false); | ||
| doTest(conf); |
Member
There was a problem hiding this comment.
how about:
elapsedWithWarmupMS = doTest(conf)
conf.setWarmUpEnable(false);
elapsedWithoutWarmupMS = doTest(conf);
assertTrue(elapsedWithWarmupMS < elapsedWithoutWarmupMS)
Collaborator
|
/run-all-tests |
Signed-off-by: birdstorm <[email protected]>
ti-srebot
approved these changes
Dec 24, 2021
Member
|
/merge |
Collaborator
|
/run-all-tests |
ti-srebot
pushed a commit
to ti-srebot/client-java
that referenced
this pull request
Dec 24, 2021
Signed-off-by: ti-srebot <[email protected]>
Collaborator
|
cherry pick to release-3.1 in PR #438 |
birdstorm
added a commit
to ti-srebot/client-java
that referenced
this pull request
Dec 24, 2021
birdstorm
added a commit
to ti-srebot/client-java
that referenced
this pull request
Dec 28, 2021
Signed-off-by: birdstorm <[email protected]>
birdstorm
added a commit
to ti-srebot/client-java
that referenced
this pull request
Dec 28, 2021
Signed-off-by: birdstorm <[email protected]>
zz-jason
pushed a commit
that referenced
this pull request
Dec 30, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
use scanRegions request with limit to warm up client.
new configurations: