[to #763] Pick bug fixes of API v2 codec to master - #769
Merged
Conversation
…v#765) Signed-off-by: iosmanthus <[email protected]> Signed-off-by: Ping Yu <[email protected]>
* fix region decoding Signed-off-by: iosmanthus <[email protected]> * add test for decodeRegion Signed-off-by: iosmanthus <[email protected]> * add more tests for decodeRegion Signed-off-by: iosmanthus <[email protected]> --------- Signed-off-by: iosmanthus <[email protected]> Signed-off-by: Ping Yu <[email protected]>
* complement v2 codec unit test cases. Signed-off-by: Ping Yu <[email protected]> * fix fmt Signed-off-by: Ping Yu <[email protected]> --------- Signed-off-by: Ping Yu <[email protected]>
Codecov ReportAttention:
... and 6 files with indirect coverage changes 📢 Thoughts on this report? Let us know!. |
iosmanthus
approved these changes
Oct 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #763
Problem Description: decode EpochNotMatch should ignore invalid region
What is changed and how does it work?
Cherry pick from release-3.3.1.14:
Code changes
Check List for Tests
This PR has been tested by at least one of the following methods:
Side effects
Related changes