ci: surface public API changes on pull requests#3274
Merged
Conversation
Member
Author
|
Could provide useful insights when reviewing PRs. BC can be easily missed. From https://seld.be/notes/surfacing-public-api-changes/ We can give it a try and see if that fits. |
Add composer/api-surface-check, which statically diffs the public API surface of changed PHP files and posts a summary comment on PRs. Split into a permissionless pull_request trigger and a workflow_run comment workflow so fork PRs are analyzed without granting them write access.
5eb5277 to
47352b8
Compare
Member
|
@nlemoine Awesome, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add composer/api-surface-check, which statically diffs the public API surface of changed PHP files and posts a summary comment on PRs. Split into a permissionless pull_request trigger and a workflow_run comment workflow so fork PRs are analyzed without granting them write access.