rp2: disable digital input for analog inputs #4939
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is what the Pico SDK does[0] and may fix tinygo-org#4936. [0] https://github.com/raspberrypi/pico-sdk/blob/ee68c78d0afae2b69c03ae1a72bf5cc267a2d94c/src/rp2_common/hardware_adc/include/hardware/adc.h#L101
|
I tested it, it fixes the issue from #4936 $ ./tinygo_pr4939/tinygo/bin/tinygo flash -target=pico2 -monitor read_temp.go
Connected to /dev/cu.usbmodem1101. Press Ctrl-C to exit.
Thermistor Temperature Monitor
==============================
Debug - ADC: 30080, Voltage: 1.515V
ADC: 30080, 20.8 °C
Debug - ADC: 30112, Voltage: 1.516V
ADC: 30112, 20.9 °C
Debug - ADC: 30160, Voltage: 1.519V
ADC: 30160, 20.9 °C
Debug - ADC: 30112, Voltage: 1.516V
ADC: 30112, 20.9 °C
Debug - ADC: 30240, Voltage: 1.523V
ADC: 30240, 21.1 °C |
|
Good to hear. I believe errata RP2350-E9 is the likely reason this change makes a difference on rp2350 and not rp2040. |
|
Thank you for the quick fix here @eliasnaur and to @mietzen for reporting and verifying. Now merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is what the Pico SDK does[0] and may fix #4936.
Untested.
[0] https://github.com/raspberrypi/pico-sdk/blob/ee68c78d0afae2b69c03ae1a72bf5cc267a2d94c/src/rp2_common/hardware_adc/include/hardware/adc.h#L101