Ensure mtl_basedir ends with a directory separator #176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Super awesome! I'll check appveyor failure and merge as soon as possible. |
|
I didn't check this yet on Windows; the only issue I can think of is, if you pass a |
|
Ok, tested on Windows and apparently it works for whichever combination of separators. |
|
Merged! Build failure was another reason. I have fixed it by another commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if
mtl_basedirdoesn't end with a separator character (/on *nix or\\on Windows) the loader will neither raise any warning nor correctly load the materials.With this commit,
LoadObjwill automatically insert a separator at the end of the basedir if needed.