Change triangulation loop termination constraint #192
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome! Thanks!
Yes, it would be nice if we have an uint test for regression. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When loading large concave polygons (with triangulation enabled) I found that the resulting mesh was sometimes missing triangles. The issue seems to be the hard stop on 10 max iterations over the face vertices.
The change introduced here relaxes that constraint but avoids an endless loop in case no progress is made after a complete iteration through all the vertices. It should be noted however that the time bound for the worst case after this change is higher than with the 10 iterations constraint.
If you think this change is worth considering I can add a test case that doesn't pass with current implementation and is fixed by this change.