Fix normal flipping during triangulation #340
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-Update triangulation routine to use Newell's method to ensure polygons aren't flipped when triangulated -Don't triangulate when npolys == 3
|
@tylermorganwall Awesome! I will do double-check with dataset in #319 BTW PR requires some compilation fixes. |
-Remove dependency on C++11 by using a custom struct instead of an std::array
…nwall/tinyobjloader into triangulation-fix
-Fix compilation by adding default constructor and remove array access
-Fix struct constructor
-Change array access to struct member
|
I fixed the compilation issues by replacing std::array with a custom struct, which should remove the C++11 dependency |
|
@tylermorganwall Awesme! At least confirmed the PR now compiles well on C++03 + clang and gcc on my side. Polygon tessellation seems working well on my local test, so merged! You can ignore some CI build failure, which is related to Python things. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes the triangulation issue by implementing Newell's method to ensure polygons aren't flipped, as well as turns off triangulation for faces when
npolys == 3. I have confirmed it fixes all flipped normals on multiple large datasets with many polygonal faces. This fixes issue #319 .