Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix parsing of comments at the end of lines for tokens with variable number of elements. (#389) #390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 23, 2024

Conversation

scschaefer
Copy link
Contributor

@scschaefer scschaefer commented Nov 22, 2024

This pull request should fix the problem described in issue #389 by cancelling the while loop when a # comment character is found.
Everything that follows after the # can be assumed to be part of the comment and should thus not be parsed.

@syoyo
Copy link
Collaborator

syoyo commented Nov 22, 2024

Thanks! PR should fix the issue #389.

I'd like to add an unit test of issue #389 to https://github.com/tinyobjloader/tinyobjloader/blob/release/tests/tester.cc
Is it ok to add linien.obj test scene in #389 to here https://github.com/tinyobjloader/tinyobjloader/tree/release/models ?

@scschaefer
Copy link
Contributor Author

Thanks for the quick review! 🙂
Adding the file to the models folder should be fine. 👍

@syoyo syoyo merged commit 3201329 into tinyobjloader:release Nov 23, 2024
10 checks passed
@syoyo
Copy link
Collaborator

syoyo commented Nov 23, 2024

Thanks! PR has been merged, and added a regression test in this commit: fe9e713

@scschaefer
Copy link
Contributor Author

scschaefer commented Nov 23, 2024

Thank you for merging my PR! 🙂
Could you please tag commit fe9e713 as v2.0.0rc14?

We use tinyobjloader via vcpkg, and a new version tag would make it much easier to submit a pull request to update the vcpkg port.

Thanks again for your time!

@syoyo
Copy link
Collaborator

syoyo commented Nov 24, 2024

I don't recommend to use vcpkg, since tinyobjloader is header-only library. Copying a header file is the recommended way.

@scschaefer
Copy link
Contributor Author

While I agree with you, I don't have a choice, as our approved workflow mandates using vcpkg for our C++ backend. We use vcpkg not just to include external packages but also to automatically parse the packages' meta-info to check whether the necessary licenses are included in our setup, the package's version is up to date, etc. That wouldn't work if I included the header directly in our solution. 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants