Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add test for Option passed to wrong routines #1729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 22, 2022
Merged

Add test for Option passed to wrong routines #1729

merged 1 commit into from
May 22, 2022

Conversation

shadowspawn
Copy link
Collaborator

Pull Request

Problem

Missing test coverage for throw if pass Option to .option() or .requiredOption().

Solution

Add tests.

abetomo
abetomo approved these changes May 22, 2022
View reviewed changes
Copy link
Collaborator

@abetomo abetomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@shadowspawn shadowspawn merged commit 1bab84c into tj:develop May 22, 2022
@shadowspawn shadowspawn added the pending release Merged into a branch for a future release, but not released yet label May 22, 2022
@shadowspawn shadowspawn deleted the feature/add-test-for-author-error branch May 22, 2022 01:36
@shadowspawn shadowspawn removed the pending release Merged into a branch for a future release, but not released yet label May 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abetomo abetomo abetomo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shadowspawn @abetomo