feat(duckdb): Add transpilation support for ARRAY_SLICE function#7188
Open
fivetran-amrutabhimsenayachit wants to merge 1 commit intomainfrom
Open
feat(duckdb): Add transpilation support for ARRAY_SLICE function#7188fivetran-amrutabhimsenayachit wants to merge 1 commit intomainfrom
fivetran-amrutabhimsenayachit wants to merge 1 commit intomainfrom
Conversation
Contributor
SQLGlot Integration Test ResultsComparing:
By Dialect
Overallmain: 14651 total, 13072 passed (pass rate: 89.2%), sqlglot version: sqlglot:RD-1147629-array-slice: 14651 total, 13083 passed (pass rate: 89.3%), sqlglot version: Transitions: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem : Snowflake is 0-indexed exclusive-end; DuckDB is 1-indexed inclusive-end. SQLGlot generates no index adjustments, producing wrong results for any from > 0 or negative to values.
Example:
Snowflake: SELECT ARRAY_SLICE([1,2,3,4,5], 1, 3) → [2, 3]
DuckDB naive: ARRAY_SLICE([1,2,3,4,5], 1, 3) → [1, 2, 3] ✗
DuckDB fixed: ARRAY_SLICE([1,2,3,4,5], 2, 3) → [2, 3] ✓