Tock 2.0: nonvolatile storage & app flash driver #159
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a BADRVAL error definition with an assigned value of 1024 as per the Tock 2.0 system call TRD. This can be returned in case a driver provides an unexpected system call return variant, which the userspace wrapper does not know how to handle.
1a7af65 to
ab56eaa
Compare
alistair23
approved these changes
Jan 21, 2021
hudson-ayers
approved these changes
Jan 21, 2021
|
bors r+ |
|
Build succeeded: |
tyler-potyondy
pushed a commit
to tyler-potyondy/libtock-c
that referenced
this pull request
Mar 13, 2024
151: Tock 2.0: touch api and example app for 2.0 API r=phil-levis a=alexandruradovici This pull request adds the touch driver API and example. It should close tock#126 156: Tock 2.0/rng: fix rng_sync yield for callback r=phil-levis a=lschuermann ### Pull Request Overview This fixes a bug introduced with the Tock 2.0 RNG migration, where the `rng_sync` function would return prior to `yield`ing for the callback to occur. I did test the previous PR (tock#146), although I've hit the bugs of tock#154 so my testing methodology wasn't as thorough as I'd hoped it would be (had limited access to ARM boards then). Fixes: f284e25 ("Update RNG to Tock 2.0 system call interface") ### Testing Strategy This pull request was tested by running the `rng` and `number_guess_game` test apps on a Hail. ### TODO or Help Wanted N/A ### Formatting - [x] Ran uncrustify. 157: Tock 2.0: sound pressure API r=phil-levis a=alexandruradovici This PR adds the user space API for the sound pressure driver (tock/tock#2364) and adds the sound pressure driver to the example sensors app. 158: Tock 2.0: ninedof driver API r=phil-levis a=alexandruradovici The PR updates the ninedof driver API. 159: Tock 2.0: nonvolatile storage & app flash driver r=phil-levis a=lschuermann ### Pull Request Overview This pull request ports both the nonvolatile storage driver and the app flash driver to the Tock 2.0 system call interface. It's the counterpart to tock/tock#2362. It furthermore adds a `BADRVAL` error, as indicated in the Tock 2.0 TRD. Drivers can return this error code (with an assigned value of `-1024`) in case a kernel driver returns an unexpected variant which they do not know how to handle. ### Testing Strategy This pull request was tested by running the `nonvolatile_storage` and `app_state` tests on the accompanying [kernel PR](tock/tock#2362). ### TODO or Help Wanted N/A ### Formatting - [x] Ran uncrustify. Co-authored-by: Alexandru Radovici <[email protected]> Co-authored-by: Leon Schuermann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
This pull request ports both the nonvolatile storage driver and the app flash driver to the Tock 2.0 system call interface. It's the counterpart to tock/tock#2362.
It furthermore adds a
BADRVALerror, as indicated in the Tock 2.0 TRD. Drivers can return this error code (with an assigned value of-1024) in case a kernel driver returns an unexpected variant which they do not know how to handle.Testing Strategy
This pull request was tested by running the
nonvolatile_storageandapp_statetests on the accompanying kernel PR.TODO or Help Wanted
N/A
Formatting