Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

gkelly
Copy link
Contributor

@gkelly gkelly commented Nov 19, 2020

Pull Request Overview

This pull request renames boards/opentitan to boards/earlgrey-nexysvideo.

Testing Strategy

This pull request was tested by running make allboards and make prepush.

Documentation Updated

  • Updated the relevant files in /docs, or no updates are required.

Formatting

  • Ran make prepush.

@alistair23
Copy link
Contributor

Looks like the CI is failing with formatting issues.

@gkelly
Copy link
Contributor Author

gkelly commented Nov 19, 2020

Looks like the CI is failing with formatting issues.

Strange, make prepush and make ci-job-format both run cleanly on my checkout.

@gkelly gkelly force-pushed the rename-opentitan branch 2 times, most recently from d804f0f to 5ef1d53 Compare November 19, 2020 17:09
alistair23
alistair23 previously approved these changes Nov 19, 2020
alistair23
alistair23 previously approved these changes Nov 19, 2020
@gkelly
Copy link
Contributor Author

gkelly commented Nov 19, 2020

The netlify presubmit check shouldn't block submission, right?

@alistair23
Copy link
Contributor

Nope, it's broken and no one can see why apparently: #2201

@gkelly gkelly requested review from bradjc and a team November 19, 2020 17:59
Copy link
Contributor

@hudson-ayers hudson-ayers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably change the name of the board in boards/README and doc/wg/opentitan/README.md as well, but I can't put suggestions in those files.

@bradjc bradjc added the WG-OpenTitan In the purview of the OpenTitan working group. label Nov 19, 2020
@gkelly
Copy link
Contributor Author

gkelly commented Nov 19, 2020

We should probably change the name of the board in boards/README and doc/wg/opentitan/README.md as well, but I can't put suggestions in those files.

I did change the boards/README.md file to call it out as "Earlgrey on Nexys Video".

@hudson-ayers
Copy link
Contributor

I did change the boards/README.md file to call it out as "Earlgrey on Nexys Video".

Sorry, I did a grep and saw an [OpenTitan] and didn't realize it was pointing to the out-of-tree board.

@gkelly gkelly merged commit db90a21 into tock:master Nov 19, 2020
@gkelly gkelly deleted the rename-opentitan branch November 19, 2020 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WG-OpenTitan In the purview of the OpenTitan working group.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants