nano33ble: increase .rom section, add process console #2236
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
This pull request increases the size of the .rom section from 128 kB to 256 kB for the nano33ble, and adds the process console to the board. The size change was necessary to fit the process console code. As an aside, the size change is also necessary to use the rubble stack in #2233.
Notably, the command for flashing apps changes because apps are now located at a different address. If, like me, you had an alias for flashing apps, you will need to update it.
Testing Strategy
Ran the process console alongside blink and hello_loop and tried out various commands.
TODO or Help Wanted
N/A
Documentation Updated
Formatting
make prepush.