reorder make prepush commands to avoid clippy bug
#2242
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alistair23
approved these changes
Dec 7, 2020
|
Given that we know about the clippy bug, shouldn't we also run |
lschuermann
approved these changes
Dec 7, 2020
|
Since this is working around a bug in clippy, let's merge now and let this PR serve as some documentation as to why those are ordered the way they are. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
Because of this bug: rust-lang/rust-clippy#4612 , sometimes
make clean && make prepushwill fail to catch clippy errors thatmake clean && make clippywill catch. In the meantime, it helps to make sure thatcargo clippyis called before any othercargocommand that actually compiles the workspace.Testing Strategy
This pull request was tested by running
make prepushon tock-2.0-dev, which had a clippy error that did not surface with the previous ordering.TODO or Help Wanted
N/A
Documentation Updated
Formatting
make prepush.