Spi controller 2.0 #2253
Merged
Spi controller 2.0 #2253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bors r+ |
lschuermann
pushed a commit
to lschuermann/tock
that referenced
this pull request
Mar 20, 2021
2253: Spi controller 2.0 r=phil-levis a=phil-levis ### Pull Request Overview This pull request updates the SPI controller syscall capsule to use the 2.0 syscall API. ### Testing Strategy This pull request was tested by running the `spi_buf` test in libtock-c. Which turns out it doesn't work, because the syscall driver for imix uses the same CS as the radio, so you see weird behavior. So I checked it with other configurations, using a logic analyzer. ### TODO or Help Wanted Once we have ported things, we will likely want to start writing tests for what happens if buffers are yanked. ### Documentation Updated - [x] Updated the relevant files in `/docs`, or no updates are required. ### Formatting - [x] Ran `make prepush`. Co-authored-by: Philip Levis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
This pull request updates the SPI controller syscall capsule to use the 2.0 syscall API.
Testing Strategy
This pull request was tested by running the
spi_buftest in libtock-c. Which turns out it doesn't work, because the syscall driver for imix uses the same CS as the radio, so you see weird behavior. So I checked it with other configurations, using a logic analyzer.TODO or Help Wanted
Once we have ported things, we will likely want to start writing tests for what happens if buffers are yanked.
Documentation Updated
/docs, or no updates are required.Formatting
make prepush.