Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Update screen driver syscalls to Tock 2.0 #2257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 14, 2020
Merged

Update screen driver syscalls to Tock 2.0 #2257

merged 2 commits into from
Dec 14, 2020

Conversation

alexandruradovici
Copy link
Contributor

Pull Request Overview

This pull request changes the screen driver to Tock 2.0

Testing Strategy

This pull request was tested using an STM32F412g discovery board.

TODO or Help Wanted

N/A

I am not exactly sure where to update the user space API, as the libtock-c branch https://github.com/tock/libtock-c/tree/tock-2.0-dev does not seem to have the userspace return codes implemented. Maybe I am missing something.

Documentation Updated

  • Updated the relevant files in /docs, or no updates are required.

Formatting

  • Ran make prepush.

@alexandruradovici alexandruradovici changed the title Update screen driver to Tock API 2.0 Update screen driver syscalls to Tock 2.0 Dec 11, 2020
hudson-ayers
hudson-ayers approved these changes Dec 11, 2020
View reviewed changes
Copy link
Contributor

@hudson-ayers hudson-ayers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@phil-levis
Copy link
Contributor

phil-levis commented Dec 11, 2020 •
edited
Loading

I am not exactly sure where to update the user space API, as the libtock-c branch https://github.com/tock/libtock-c/tree/tock-2.0-dev does not seem to have the userspace return codes implemented. Maybe I am missing something.

Good point -- we are behind on that. I updated things for memop, but they have very limited return values. I'll update the low-level routines in libtock-c today/tomorrow.

@alexandruradovici
Copy link
Contributor Author

I am not exactly sure where to update the user space API, as the libtock-c branch https://github.com/tock/libtock-c/tree/tock-2.0-dev does not seem to have the userspace return codes implemented. Maybe I am missing something.

Good point -- we are behind on that. I updated things for memop, but they have very limited return values. I'll update the low-level routines in libtock-c today/tomorrow.

Let me know if I can help in any way.

@bradjc bradjc added the tock-2.0 Issues and PRs related to Tock version 2.0. label Dec 11, 2020
@phil-levis
Copy link
Contributor

Let me know if I can help in any way.

Thanks! I think I'm all set. Here's the PR for libtock-c: tock/libtock-c#131

@phil-levis
Copy link
Contributor

bors r+

@bors
Copy link
Contributor

bors bot commented Dec 14, 2020

Build succeeded:

@bors bors bot merged commit 6017d36 into tock:tock-2.0-dev Dec 14, 2020
lschuermann pushed a commit to lschuermann/tock that referenced this pull request Mar 20, 2021
@bors @alexandruradovici @lschuermann
Merge tock#2257
ae3661e 
2257: Update screen driver syscalls to Tock 2.0 r=phil-levis a=alexandruradovici

### Pull Request Overview

This pull request changes the screen driver to Tock 2.0


### Testing Strategy

This pull request was tested using an STM32F412g discovery board.

### TODO or Help Wanted

N/A

I am not exactly sure where to update the user space API, as the libtock-c branch https://github.com/tock/libtock-c/tree/tock-2.0-dev does not seem to have the userspace return codes implemented. Maybe I am missing something.

### Documentation Updated

- [x] Updated the relevant files in `/docs`, or no updates are required.

### Formatting

- [x] Ran `make prepush`.


Co-authored-by: Alexandru Radovici <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hudson-ayers hudson-ayers hudson-ayers approved these changes

Assignees
No one assigned
Labels
tock-2.0 Issues and PRs related to Tock version 2.0.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alexandruradovici @phil-levis @hudson-ayers @bradjc