nrf52: nvmc: remove global static #2262
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alistair23
previously approved these changes
Dec 11, 2020
lschuermann
previously approved these changes
Dec 14, 2020
fbeb14f
|
I pushed a commit that removed the remaining users of the global NVMC, and also noticed that the global CLOCK variable somehow survived my initial changes as well, so I removed it (and uses of it) too. |
hudson-ayers
previously approved these changes
Dec 14, 2020
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Dec 29, 2020
2262: nrf52: nvmc: remove global static r=hudson-ayers a=bradjc ### Pull Request Overview I think that with the new static init scheme for peripherals we shouldn't have these statics anymore. I found this when using an old capsule that uses the nvmc and the state variable was somehow changing mysteriously! Turns out I had two copies of NVMC. ### Testing Strategy Implementing bootloader on nrf52840dk over USB. ### TODO or Help Wanted I don't think this will compile yet. Consider this a bug report. ### Documentation Updated - [x] Updated the relevant files in `/docs`, or no updates are required. ### Formatting - [x] Ran `make prepush`. Co-authored-by: Brad Campbell <[email protected]> Co-authored-by: Hudson Ayers <[email protected]>
|
Build failed: |
fbeb14f to
fea7e87
Compare
|
there was an implicit conflict because the added microbit board used the global CLOCK (yet another good reason to use less |
hudson-ayers
approved these changes
Jan 2, 2021
|
bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
I think that with the new static init scheme for peripherals we shouldn't have these statics anymore.
I found this when using an old capsule that uses the nvmc and the state variable was somehow changing mysteriously! Turns out I had two copies of NVMC.
Testing Strategy
Implementing bootloader on nrf52840dk over USB.
TODO or Help Wanted
I don't think this will compile yet. Consider this a bug report.
Documentation Updated
/docs, or no updates are required.Formatting
make prepush.