Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

bradjc
Copy link
Contributor

@bradjc bradjc commented Dec 22, 2020

Pull Request Overview

Add old meeting notes I have neglected to add.

Testing Strategy

This pull request was tested by...

TODO or Help Wanted

This pull request still needs...

Documentation Updated

  • Updated the relevant files in /docs, or no updates are required.

Formatting

  • Ran make prepush.

Copy link
Member

@lschuermann lschuermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

- Phil: Idea: Capsule maintains table of appslices, and uses allow number to
index the table and therefore has to swap the buffer (since that is all you
could access).
- Leon: Tried this, couldn't get it to work in Tock context.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What I wanted to say here was that this approach is doable, but has a significant overhead (as you'd have to traverse through a range of pointers prior to knowing the appslice address and length), instead of containing this information in a high-level Rust type that you own.

Sorry, might have mixed some things up in the discussion. The statement is still correct, so we can leave this in. 😄

@hudson-ayers
Copy link
Contributor

bors r+

@bors
Copy link
Contributor

bors bot commented Jan 11, 2021

@bors bors bot merged commit 757cc1f into master Jan 11, 2021
@bors bors bot deleted the core-wg-notes-bradjc branch January 11, 2021 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants