Tock 2.0: lsm303 and led matrix update to tock 2.0 api #2295
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the migration to Tock 2.0! Keeping independent changes in separate commits or PRs makes them a bit easier to review, but this doesn't look to complicated so it's fine. 😄 |
|
I made one single PR as they are both used for the microbit and changes are minimal. |
phil-levis
approved these changes
Dec 23, 2020
|
bors r+ |
|
Merge conflict. |
lschuermann
approved these changes
Dec 24, 2020
|
Resolved |
|
bors r+ |
lschuermann
pushed a commit
to lschuermann/tock
that referenced
this pull request
Mar 20, 2021
2295: Tock 2.0: lsm303 and led matrix update to tock 2.0 api r=hudson-ayers a=alexandruradovici ### Pull Request Overview This pull request updates the `lsm303xx` and `led_matrix` driver to the Tock 2.0 API. ### Testing Strategy This pull request was tested using the BBC Microbit v2 board. ### TODO or Help Wanted N/A ### Documentation Updated - [x] Updated the relevant files in `/docs`, or no updates are required. ### Formatting - [x] Ran `make prepush`. Co-authored-by: Alexandru Radovici <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
This pull request updates the
lsm303xxandled_matrixdriver to the Tock 2.0 API.Testing Strategy
This pull request was tested using the BBC Microbit v2 board.
TODO or Help Wanted
N/A
Documentation Updated
/docs, or no updates are required.Formatting
make prepush.