Updating Alarm syscall driver to 2.0 syscall API #2307
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hudson-ayers
approved these changes
Dec 24, 2020
Co-authored-by: Hudson Ayers <[email protected]>
|
bors r+ |
lschuermann
pushed a commit
to lschuermann/tock
that referenced
this pull request
Mar 20, 2021
2307: Updating Alarm syscall driver to 2.0 syscall API r=phil-levis a=phil-levis ### Pull Request Overview This pull requests updates the alarm system call driver to use the 2.0 syscall API. ### Testing Strategy This pull request was tested by running two copies of multi_alarm_test in parallel on the imix platform. I found a few bugs while doing so, which led me to update libtock-c's alarm code to use the new (reference, dt) system calls. It had still be using just an absolute time, which if there are long delays due to printfs can cause the hang-on-alarm-in-the-past bug. ### TODO or Help Wanted ### Documentation Updated - [x] Updated the relevant files in `/docs`, or no updates are required. ### Formatting - [x] Ran `make prepush`. Co-authored-by: Philip Levis <[email protected]> Co-authored-by: Hudson Ayers <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
This pull requests updates the alarm system call driver to use the 2.0 syscall API.
Testing Strategy
This pull request was tested by running two copies of multi_alarm_test in parallel on the imix platform. I found a few bugs while doing so, which led me to update libtock-c's alarm code to use the new (reference, dt) system calls. It had still be using just an absolute time, which if there are long delays due to printfs can cause the hang-on-alarm-in-the-past bug.
TODO or Help Wanted
Documentation Updated
/docs, or no updates are required.Formatting
make prepush.