Tock 2.0: update multi touch #2315
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phil-levis
approved these changes
Dec 31, 2020
| @@ -147,12 +148,13 @@ impl<'a> i2c::I2CClient for Ft6x06<'a> { | |||
| + (buffer[touch_event * 8 + 5] as u16); | |||
| let pressure = Some(buffer[touch_event * 8 + 6] as u16); | |||
There was a problem hiding this comment.
Ugh these embedded constants! I don't want to block a 2.0 update on fixing cruft like this, but fixing it seems pretty important from a maintenance perspective.
There was a problem hiding this comment.
I agree, but I'm not sure how to fix this. I can either:
- declare some consts instead of the hard coded numbers.
- have a struct instead of a buffer, but I'm not sure I can convert the struct to the array with some kind of
memcpythat would be considered safe
Any suggestion is welcome.
|
bors r+ |
|
Build succeeded! And happy new year! 🎉 |
lschuermann
pushed a commit
to lschuermann/tock
that referenced
this pull request
Mar 20, 2021
2315: Tock 2.0: update multi touch r=phil-levis a=alexandruradovici ### Pull Request Overview This pull request fixes: - a multi touch report bug for the touch driver by adding the ack command and updating the touch callbacks - the ft6x06 driver to report the touch id ### Testing Strategy This pull request was tested using an STM32F412G Discovery board. ### TODO or Help Wanted N/A ### Documentation Updated - [x] Updated the relevant files in `/docs`, or no updates are required. ### Formatting - [x] Ran `make prepush`. Co-authored-by: Alexandru Radovici <[email protected]> Co-authored-by: Vochescu Alexandru <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
This pull request fixes:
Testing Strategy
This pull request was tested using an STM32F412G Discovery board.
TODO or Help Wanted
N/A
Documentation Updated
/docs, or no updates are required.Formatting
make prepush.