Update SPI peripheral syscalls to 2.0 API #2316
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conflict with RF233.
hudson-ayers
approved these changes
Dec 31, 2020
|
bors r+ |
|
Build succeeded! And happy new year! 🎉 |
lschuermann
pushed a commit
to lschuermann/tock
that referenced
this pull request
Mar 20, 2021
2316: Update SPI peripheral syscalls to 2.0 API r=phil-levis a=phil-levis ### Pull Request Overview This pull request updates the SPI peripheral system call driver to the 2.0 Tock API. It also changes the SPI controller syscall driver to use CS2 rather than CS3 on imix. This is because CS3 is tied to the RF233. The driver originally was for a userspace RF233 driver, but since that transitioned into the kernel using CS3 causes it to conflict: SPI operations from userspace are answered by the RF233, and userspace can take control of the radio. ### Testing Strategy This pull request was tested by making a new test platform that provided peripheral syscalls through the SPI device and SPI controller syscalls through a USART device, connecting them, and testing operations. ### TODO or Help Wanted Nothing. ### Documentation Updated - [x] Updated the relevant files in `/docs`, or no updates are required. ### Formatting - [x] Ran `make prepush`. Co-authored-by: Philip Levis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
This pull request updates the SPI peripheral system call driver to the 2.0 Tock API.
It also changes the SPI controller syscall driver to use CS2 rather than CS3 on imix. This is because CS3 is tied to the RF233. The driver originally was for a userspace RF233 driver, but since that transitioned into the kernel using CS3 causes it to conflict: SPI operations from userspace are answered by the RF233, and userspace can take control of the radio.
Testing Strategy
This pull request was tested by making a new test platform that provided peripheral syscalls through the SPI device and SPI controller syscalls through a USART device, connecting them, and testing operations.
TODO or Help Wanted
Nothing.
Documentation Updated
/docs, or no updates are required.Formatting
make prepush.