kernel: move tbf code to its own library #2358
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hudson-ayers
previously approved these changes
Jan 14, 2021
alistair23
previously approved these changes
Jan 15, 2021
Turns out it is not actually needed. Co-authored-by: Hudson Ayers <[email protected]>
hudson-ayers
previously approved these changes
Jan 15, 2021
alistair23
previously approved these changes
Jan 15, 2021
jrvanwhy
reviewed
Jan 15, 2021
jrvanwhy
reviewed
Jan 15, 2021
|
I added some structure to the tbf library crate. I moved the types into their own file, and all of the parsing code into its own file. This makes it much more straightforward to add code to create tbfs in the future. |
hudson-ayers
approved these changes
Jan 18, 2021
alistair23
approved these changes
Jan 19, 2021
jrvanwhy
approved these changes
Jan 19, 2021
|
bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
As part of the effort to remove
unsafefrom the TBF parsing code (#1465), the last goal was always to move all of the TBF parsing code to its own library since by definition the kernel is not the only thing that needs to handle TBFs. Rather than have TBF code re-implemented, this would allow there to be a single TBF parsing crate that can be used by the kernel and also tools like elf2tab.Turns out, moving this to a library is quite easy. I didn't want to do this earlier in case there were fixes or updates needed to the earlier tbf parsing re-write from #1465. But since the code has been working now seems like a reasonable time to move it to a library.
Apologies to @alistair23 for moving code, but I can help update if git doesn't do it automatically.
Testing Strategy
This pull request was tested by running kernels on nano33 and hail, but really this doesn't change any logic.
TODO or Help Wanted
n/a
Documentation Updated
/docs, or no updates are required.Formatting
make prepush.