Update I2C master/slave driver to 2.0 syscall API. #2384
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alistair23
approved these changes
Jan 28, 2021
|
bors r+ |
43 tasks
lschuermann
pushed a commit
to lschuermann/tock
that referenced
this pull request
Mar 20, 2021
2384: Update I2C master/slave driver to 2.0 syscall API. r=phil-levis a=phil-levis ### Pull Request Overview This pull request updates the `i2c_master_slave_driver` capsule to the 2.0 syscall API. It does not work on the tock-2.0-dev branch currently because of tock#2380 . When tested with tock#2380 it works. Given that the libtock-c API was using the wrong driver ID, I suspect this is not a critical system call driver (it only works on imix and isn't loaded by default), so we can merge this now and later merge in master/tock#2380. ### Testing Strategy This pull request was tested by changing the imix reset handler to use this driver on I2C1 and running the `i2c_master_slave_ping_pong` test with two imix. It works. ### TODO or Help Wanted Nothing. ### Documentation Updated - [x] Updated the relevant files in `/docs`, or no updates are required. ### Formatting - [x] Ran `make prepush`. Co-authored-by: Philip Levis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
This pull request updates the
i2c_master_slave_drivercapsule to the 2.0 syscall API. It does not work on the tock-2.0-dev branch currently because of #2380 . When tested with #2380 it works. Given that the libtock-c API was using the wrong driver ID, I suspect this is not a critical system call driver (it only works on imix and isn't loaded by default), so we can merge this now and later merge in master/#2380.Testing Strategy
This pull request was tested by changing the imix reset handler to use this driver on I2C1 and running the
i2c_master_slave_ping_pongtest with two imix. It works.TODO or Help Wanted
Nothing.
Documentation Updated
/docs, or no updates are required.Formatting
make prepush.