Tock 2.0: fix system call return variant discriminators #2406
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The discriminators for the return variants - Success with u64 (131) and - Success with 3 u32 (132) were accidentally swapped in the initial implementation. This implements the correct encoding as per the Syscalls Tock Reference Document. Fixes: 78bfb87 ("Implement the 2.0 syscall return value types") Reported-by: Pat Pannuto <[email protected]> Signed-off-by: Leon Schuermann <[email protected]>
jrvanwhy
approved these changes
Feb 3, 2021
|
bors r+ |
lschuermann
added a commit
to lschuermann/tock
that referenced
this pull request
Mar 20, 2021
2406: Tock 2.0: fix system call return variant discriminators r=phil-levis a=lschuermann ### Pull Request Overview The discriminators for the return variants - Success with u64 (`131`) and - Success with 3 u32 (`132`) were accidentally swapped in the initial implementation. This implements the correct encoding as per the Syscalls Tock Reference Document. Fixes: 78bfb87 ("Implement the 2.0 syscall return value types") Reported-by: Pat Pannuto <[email protected]> (@ppannuto) in tock#2394 ### Testing Strategy This pull request was not tested. It was verified that `libtock-c` does indeed use the correct encoding as specified in the TRD. ### TODO or Help Wanted N/A ### Documentation Updated - [x] Updated the relevant files in `/docs`, or no updates are required. ### Formatting - [x] Ran `make prepush`. Co-authored-by: Leon Schuermann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
The discriminators for the return variants
131) and132)were accidentally swapped in the initial implementation. This implements the correct encoding as per the Syscalls Tock Reference Document.
Fixes: 78bfb87 ("Implement the 2.0 syscall return value types")
Reported-by: Pat Pannuto [email protected] (@ppannuto) in #2394
Testing Strategy
This pull request was not tested. It was verified that
libtock-cdoes indeed use the correct encoding as specified in the TRD.TODO or Help Wanted
N/A
Documentation Updated
/docs, or no updates are required.Formatting
make prepush.