RFC: Add install make target for boards
#2440
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tock has had a long standing convention of two makefile targets for boards to load a kernel onto a board. - flash: Uses JTAG to flash the kernel. - program: Uses UART and a bootloader to flash the kernel. This is helpful because some boards support both but require different hardware, and it gives the user some idea of what tools will be needed to load the kernel. However, for new users they must figure out which is appropriate if a board supports both. Often there is one target that experienced users just know to use, and we should make this more clear to new users. Also, having different targets on diferent boards complicates writing a common tutorial guide for multiple platforms. This patch adds a new target `make install` that just uses the default for the platform. The expectation is that most users can install the kernel using `make install`. The other targets are of course there for users who need something more specific.
Co-authored-by: Hudson Ayers <[email protected]>
alistair23
previously approved these changes
Feb 18, 2021
hudson-ayers
approved these changes
Feb 25, 2021
ppannuto
approved these changes
Feb 25, 2021
alistair23
approved these changes
Mar 3, 2021
|
bors r+ |
lschuermann
pushed a commit
to lschuermann/tock
that referenced
this pull request
Mar 20, 2021
2440: RFC: Add `install` make target for boards r=ppannuto a=bradjc
Tock has had a long standing convention of two makefile targets for boards to load a kernel onto a board.
1. flash: Uses JTAG to flash the kernel.
1. program: Uses UART and a bootloader to flash the kernel.
This is helpful because some boards support both but require different hardware, and it gives the user some idea of what tools will be needed to load the kernel.
However, new users must figure out which is appropriate if a board supports both. Often there is one target that experienced users just know to use, and we should make this more clear to new users. Also, having different targets on different boards complicates writing a common tutorial guide for multiple platforms.
This patch adds a new target `make install` that just uses the default for the platform. The expectation is that most users can install the kernel using `make install`. The other targets are of course there for users who need something more specific.
### Testing Strategy
This pull request was tested by using `make install` to flash the kernel on hail.
### TODO or Help Wanted
Thoughts?
### Documentation Updated
- [x] Updated the relevant files in `/docs`, or no updates are required.
### Formatting
- [x] Ran `make prepush`.
2449: arch: cortex-m: update to asm! r=ppannuto a=bradjc
### Pull Request Overview
This pull request switches the last llvm_asm in cortex-m to asm.
This was somewhat straightforward, except that Rust will not let me mark r6 as clobbered (`out("r6") _`) like the other registers. I get:
```
error: invalid register `r6`: r6 is used internally by LLVM and cannot be used as an operand for inline asm
--> arch/cortex-m/src/lib.rs:254:31
|
254 | out("r4") _, out("r5") _, out("r6") _, out("r8") _, out("r9") _,
| ^^^^^^^^^^^
```
I found that if I manually saved r6 in r3 the kernel still works.
tock#1923
### Testing Strategy
Running hail app on hail.
### TODO or Help Wanted
n/a
### Documentation Updated
- [x] Updated the relevant files in `/docs`, or no updates are required.
### Formatting
- [x] Ran `make prepush`.
Co-authored-by: Brad Campbell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tock has had a long standing convention of two makefile targets for boards to load a kernel onto a board.
This is helpful because some boards support both but require different hardware, and it gives the user some idea of what tools will be needed to load the kernel.
However, new users must figure out which is appropriate if a board supports both. Often there is one target that experienced users just know to use, and we should make this more clear to new users. Also, having different targets on different boards complicates writing a common tutorial guide for multiple platforms.
This patch adds a new target
make installthat just uses the default for the platform. The expectation is that most users can install the kernel usingmake install. The other targets are of course there for users who need something more specific.Testing Strategy
This pull request was tested by using
make installto flash the kernel on hail.TODO or Help Wanted
Thoughts?
Documentation Updated
/docs, or no updates are required.Formatting
make prepush.