Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

alistair23
Copy link
Contributor

Pull Request Overview

This PR adds support for the two internal timers. This means we now don't have to mux the RISC-V mtimer.

Testing Strategy

Running in simulation.

TODO or Help Wanted

Documentation Updated

  • Updated the relevant files in /docs, or no updates are required.

Formatting

  • Ran make prepush.

@github-actions github-actions bot added the arch/risc-v RISC-V architecture label Mar 22, 2021
The RISC-V spec specifies that bits 16 and above are avaliable for
custom implementations. To allow chips to use these bits let's specify
them in the register bitfield.

Signed-off-by: Alistair Francis <[email protected]>
@alistair23 alistair23 force-pushed the alistair/swervolf-timer branch from 374fdeb to a290235 Compare March 23, 2021 16:29
@hudson-ayers
Copy link
Contributor

For earlgrey, I recall we used a CONFIG option to set a different prescalar based on whether the chip was running on an FPGA or in verilator. Do we need something like that here?

@alistair23
Copy link
Contributor Author

I don't have the FPGA board so I haven't tested this on the FPGA. The Tock board readme only talks about the simulation.

Apparently the FPGA and simulation have the same frequency though (if I'm reading the system verilog correctly).

@hudson-ayers
Copy link
Contributor

I think the issue was that using the same frequency in verilator made running anything meaningful unbearably slow. But if this seems to work fine in practice, sounds good to me.

Copy link
Contributor

@hudson-ayers hudson-ayers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

@bors
Copy link
Contributor

bors bot commented Mar 29, 2021

@bors bors bot merged commit 61d9a94 into tock:master Mar 29, 2021
@alistair23 alistair23 deleted the alistair/swervolf-timer branch March 30, 2021 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arch/risc-v RISC-V architecture
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants