Rename AppId to ProcessId (v2) #2507
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will approve this once it passes CI, the general approach looks good to me |
alistair23
previously approved these changes
Apr 2, 2021
7005e81 to
749a555
Compare
749a555 to
c03461c
Compare
|
This is ready to go after #2506. |
|
Re-opening, GH closed it because the base branch was deleted by bors. |
c03461c to
bdef8a6
Compare
|
bors try |
|
|
hudson-ayers
approved these changes
Apr 16, 2021
|
netlify passed on #2537 though, despite running after the failure on this PR. And I re-tried netlify 3 times on this PR |
|
I don't want to wait for netlify. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
This pull request is an update to #2184 which:
AppIdtoProcessId..appid()to.processid().Process.app_idtoProcess.id.It does not update type names. I'm generally opposed to variable renaming, but that can be added to this PR. It's also more tricky to get correct.
Testing Strategy
travis
TODO or Help Wanted
More renaming maybe? Get rid of all
app*idin Tock?Documentation Updated
/docs, or no updates are required.Formatting
make prepush.