Thanks to visit codestin.com
Credit goes to github.com

Skip to content

opentitan: Bump the OpenTitan bitstream SHA and enable ePMP #2509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 17, 2021
Merged

opentitan: Bump the OpenTitan bitstream SHA and enable ePMP #2509

merged 6 commits into from
May 17, 2021

Conversation

alistair23
Copy link
Contributor

@alistair23 alistair23 commented Mar 30, 2021 •
edited
Loading

Pull Request Overview

This PR updates the OpenTitain bitstream to use a new SHA.

As part of this update the:

  • Interrupt mappings have updated
  • The PLIC memory addresses have been updated
  • The HMAC memory address has been updated and a bug was fixed
  • The I2C device has been changed to i2c0
  • The README has been updated

This PR also enables ePMP on Tock as that is now supported in OpenTitan.

Testing Strategy

Tested by running a few libtock-c apps on OT.

TODO or Help Wanted

  • Update QEMU
  • Address failing test cases:
    • earlgrey_nexysvideo_blink
    • earlgrey_nexysvideo_c_hello_and_printf_long
    • earlgrey_nexysvideo_blink_and_c_hello_and_buttons
    • earlgrey_nexysvideo_console_recv_short
    • earlgrey_nexysvideo_console_timeout
    • earlgrey_nexysvideo_stack_size_test1
    • earlgrey_nexysvideo_stack_size_test2
    • earlgrey_nexysvideo_mpu_stack_growth
    • earlgrey_nexysvideo_mpu_walk_region
    • earlgrey_nexysvideo_multi_alarm_test

Documentation Updated

  • Updated the relevant files in /docs, or no updates are required.

Formatting

  • Ran make prepush.

@github-actions github-actions bot added the WG-OpenTitan In the purview of the OpenTitan working group. label Mar 30, 2021
@lschuermann
Copy link
Member

Looks good so far (although I couldn't test it). You aren't yet updating the URL of the Google-hosted OpenTitan snapshot. Is that still coming or not required?

@alistair23
Copy link
Contributor Author

Ideally we would update the snapshot, but we don't have to as the ROM doesn't use interrupts. As it requires a manual update from someone at lowRISC (I'm not sure who) I'm just going to leave it.

@alistair23 alistair23 changed the title opentitan: Bump the OpenTitan bitstream SHA opentitan: Bump the OpenTitan bitstream SHA and enable ePMP Apr 7, 2021
@github-actions github-actions bot added arch/risc-v RISC-V architecture tock-libraries This affects libraries supported by the Tock project labels Apr 7, 2021
@bradjc bradjc added the blocked-upstream Waiting on something from an upstream project label Apr 14, 2021
@bradjc bradjc added the release-blocker Issue or PR that must be resolved before the next release label May 3, 2021
alistair23 added 4 commits May 13, 2021 09:18
@alistair23
opentitan: Bump the OpenTitan bitstream SHA
e8ee97f 
Signed-off-by: Alistair Francis <[email protected]>
@alistair23
libraries/riscv-csr: Update the ePMP CSR addresses
7eb4b53 
Signed-off-by: Alistair Francis <[email protected]>
@alistair23
arch/rv32i: Don't try to set the locked RLB
e88ed2e 
Signed-off-by: Alistair Francis <[email protected]>
@alistair23
arch/rv32i: pmp: Ensure we set the end address before enabling region
4424339 
Ensure that we send the end address before we enable PMP on the region.

Signed-off-by: Alistair Francis <[email protected]>
@alistair23
OpenTitan: Enable ePMP
354219d 
Signed-off-by: Alistair Francis <[email protected]>
@alistair23 alistair23 marked this pull request as ready for review May 12, 2021 23:35
@alistair23
Copy link
Contributor Author

This is ready to go!

@bradjc bradjc added last-call Final review period for a pull request. and removed blocked-upstream Waiting on something from an upstream project labels May 14, 2021
@bradjc
Copy link
Contributor

bradjc commented May 17, 2021

bors r+

@bors
Copy link
Contributor

bors bot commented May 17, 2021

Build succeeded:

@bors bors bot merged commit 9014775 into tock:master May 17, 2021
@alistair23 alistair23 deleted the alistair/ot-bump branch May 17, 2021 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bradjc bradjc bradjc approved these changes

Assignees
No one assigned
Labels
arch/risc-v RISC-V architecture last-call Final review period for a pull request. release-blocker Issue or PR that must be resolved before the next release tock-libraries This affects libraries supported by the Tock project WG-OpenTitan In the purview of the OpenTitan working group.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alistair23 @lschuermann @bradjc